c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
a4d61a4be4
ooni-probe-cli/internal/engine
History
Simone Basso a4d61a4be4
fix(netxlite): close quic packetconn (#407) 
Noticed when working on https://github.com/ooni/probe/issues/1505.

Justification for this diff:

1. [DialEarlyContext calls dialContext with the last argument set to false](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L153);

2. [the semantics of the last argument is whether we own the connection](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L187);

3. [this value is propagated to the client data structure](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L269);

4. [client.dial](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L302) runs the session in a background goroutine and only destroys the `packetHandlers` when the connection is owned;

5. [packetHandlerMap.Destroy](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/packet_handler_map.go#L293) closes the underlying PacketConn.

6. also, the documentation clearly states that when you use `DialEarlyContext` you can use the same packet conn multiple times, so it does not take ownership.
2021-06-25 17:58:42 +02:00
..
experiment refactor: merge tlsx into netxlite (#403) 2021-06-25 12:39:45 +02:00
geolocate cleanup(all): stop using deprecated ioutil functions (#381) 2021-06-15 14:01:45 +02:00
httpheader Release 3.10.0 beta.3 (#345) 2021-05-13 08:16:28 +02:00
httpx fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
internal refactor: move bytecounter to internal (#391) 2021-06-22 13:00:29 +02:00
legacy refactor: move tlsdialer to netxlite (#404) 2021-06-25 13:42:48 +02:00
mockable feat: tutorial on how to write the torsf experiment (#390) 2021-06-22 00:12:03 +02:00
model refactor: move scrubbingLogger to the scrubber pkg (#394) 2021-06-22 14:43:58 +02:00
netx fix(netxlite): close quic packetconn (#407) 2021-06-25 17:58:42 +02:00
probeservices feat: tutorial on how to write the torsf experiment (#390) 2021-06-22 00:12:03 +02:00
testdata fix: add missing files causing tests to fail (#202) 2021-02-02 14:18:22 +01:00
.gitignore feat: support embedding encrypted psiphon config (#285) 2021-04-02 17:36:06 +02:00
allexperiments.go feat(torsf): experiment that bootstraps tor using snowflake (#387) 2021-06-18 13:51:18 +02:00
experiment_integration_test.go refactor(inputloader): better docs and naming (#265) 2021-03-26 09:34:27 +01:00
experiment_internal_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experiment_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experiment.go refactor: move bytecounter to internal (#391) 2021-06-22 13:00:29 +02:00
experimentbuilder_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experimentbuilder.go refactor(inputloader): better docs and naming (#265) 2021-03-26 09:34:27 +01:00
inputloader_network_test.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
inputloader_test.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
inputloader.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
inputprocessor_test.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
inputprocessor.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
kvstore.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
saver_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
saver.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
session_integration_test.go cleanup(all): stop using deprecated ioutil functions (#381) 2021-06-15 14:01:45 +02:00
session_internal_test.go fix(session): make sure tunnel code is tested (#301) 2021-04-05 19:51:41 +02:00
session_nopsiphon_test.go fix(session): make sure tunnel code is tested (#301) 2021-04-05 19:51:41 +02:00
session_nopsiphon.go fix(session): make sure tunnel code is tested (#301) 2021-04-05 19:51:41 +02:00
session_psiphon_test.go feat: support embedding encrypted psiphon config (#285) 2021-04-02 17:36:06 +02:00
session_psiphon.go fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
session.go refactor: move bytecounter to internal (#391) 2021-06-22 13:00:29 +02:00
submitter_test.go refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
submitter.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00