c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
a4d61a4be4
ooni-probe-cli/internal
History
Simone Basso a4d61a4be4
fix(netxlite): close quic packetconn (#407) 
Noticed when working on https://github.com/ooni/probe/issues/1505.

Justification for this diff:

1. [DialEarlyContext calls dialContext with the last argument set to false](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L153);

2. [the semantics of the last argument is whether we own the connection](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L187);

3. [this value is propagated to the client data structure](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L269);

4. [client.dial](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/client.go#L302) runs the session in a background goroutine and only destroys the `packetHandlers` when the connection is owned;

5. [packetHandlerMap.Destroy](https://github.com/lucas-clemente/quic-go/blob/v0.21.1/packet_handler_map.go#L293) closes the underlying PacketConn.

6. also, the documentation clearly states that when you use `DialEarlyContext` you can use the same packet conn multiple times, so it does not take ownership.
2021-06-25 17:58:42 +02:00
..
atomicx doc: cleanup and improve for recently moved pkgs (#354) 2021-06-04 11:39:00 +02:00
bytecounter refactor: rename i/e/n/mockablex => i/netxmocks (#397) 2021-06-23 16:06:02 +02:00
cmd refactor: move tls handshaker to netxlite (#400) 2021-06-25 11:07:26 +02:00
engine fix(netxlite): close quic packetconn (#407) 2021-06-25 17:58:42 +02:00
fsx fix(all): introduce and use iox.CopyContext (#380) 2021-06-15 13:44:28 +02:00
humanize fix(all): introduce and use iox.CopyContext (#380) 2021-06-15 13:44:28 +02:00
iox fix(all): introduce and use iox.CopyContext (#380) 2021-06-15 13:44:28 +02:00
kvstore doc: cleanup and improve for recently moved pkgs (#354) 2021-06-04 11:39:00 +02:00
mlablocate refactor(mlablocate*): move from i/e/internal to internal (#385) 2021-06-15 19:51:03 +02:00
mlablocatev2 refactor(mlablocate*): move from i/e/internal to internal (#385) 2021-06-15 19:51:03 +02:00
multierror doc: cleanup and improve for recently moved pkgs (#354) 2021-06-04 11:39:00 +02:00
netxlite fix(netxlite): close quic packetconn (#407) 2021-06-25 17:58:42 +02:00
netxmocks refactor: move quicdialing base functionality to netxlite (#406) 2021-06-25 17:04:24 +02:00
ooapi fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
platform doc: improve and reference existing bug in the code (#356) 2021-06-04 12:50:23 +02:00
ptx refactor: rename i/e/n/mockablex => i/netxmocks (#397) 2021-06-23 16:06:02 +02:00
randx doc: improve and reference existing bug in the code (#356) 2021-06-04 12:50:23 +02:00
runtimex refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
scrubber refactor: move scrubbingLogger to the scrubber pkg (#394) 2021-06-22 14:43:58 +02:00
shellx cleanup(shellx): do not directly depend on apex/log (#357) 2021-06-04 14:02:18 +02:00
tunnel cleanup(all): stop using deprecated ioutil functions (#381) 2021-06-15 14:01:45 +02:00
tutorial feat: tutorial on how to write the torsf experiment (#390) 2021-06-22 00:12:03 +02:00
version chore: we are now at 3.11.0-alpha (#361) 2021-06-08 10:08:13 +02:00
README.md doc: ensure all top dirs have an explanatory README (#214) 2021-02-03 16:54:00 +01:00

README.md

Directory github.com/ooni/probe-cli/internal

This directory contains private Go packages.