Go to file
Simone Basso 7cde93fca4
Make sure ooniprobe show <id> is WAI (#61)
1. the description of the command and the helper function are
clear hints that the command is intended to show a single JSON
measurement at a time (also the use case seems clear) [*]

2. the function used to read lines was failing for all my
measurements that take input. Since that was not the optimal
pattern anyway, use a better pattern to fix it.

3. some changes are automatically applied by my editor (VSCode
with the Go plugin) and I am fine with them.

4. while reading code, I also applied my preferred pattern
wrt whitespaces, i.e.: no whitespace inside functions, if a
function feels too long in this way, just break it.

Closes #57

[*] Even if we want to show many measurements at a time, which
does not seem needed, given the UI patterns, this functionality
won't be P0. What is P0 is to bless a new beta and give to
@sarathms binaries for all archs that support a basic `show`.
2019-10-03 11:18:07 +02:00
cmd/ooniprobe Rename the binary as ooniprobe (#58) 2019-10-02 19:27:15 +02:00
config Implement the show command (#53) 2019-10-02 18:23:14 +02:00
data Strip the trailing slash from the bouncer url 2018-09-26 15:35:17 +02:00
internal Make sure ooniprobe show <id> is WAI (#61) 2019-10-03 11:18:07 +02:00
nettests Implement the show command (#53) 2019-10-02 18:23:14 +02:00
scripts Rename the binary as ooniprobe (#58) 2019-10-02 19:27:15 +02:00
testdata Implement the show command (#53) 2019-10-02 18:23:14 +02:00
utils Use ooni/probe-engine: episode 1 (#42) 2019-05-23 16:38:46 +02:00
version Use ooni/probe-engine: episode 1 (#42) 2019-05-23 16:38:46 +02:00
.dockerignore Ignore dist in .dockerignore 2019-05-15 17:44:00 +02:00
.gitignore Use MK v0.10.x, zap legacy GeoIP, build also on Linux (#29) 2019-05-15 15:48:06 +03:00
.goreleaser.yml Remove getCaBundlePath 2019-05-15 19:25:23 +02:00
.travis.yml Implement the show command (#53) 2019-10-02 18:23:14 +02:00
build.sh Rename the binary as ooniprobe (#58) 2019-10-02 19:27:15 +02:00
Dockerfile Integrate further with ooni/probe-engine: episode two (#46) 2019-08-15 18:08:43 +02:00
go.mod Upgrade to ooni/probe-engine@v0.1.1 (#60) 2019-10-03 09:43:25 +02:00
go.sum Upgrade to ooni/probe-engine@v0.1.1 (#60) 2019-10-03 09:43:25 +02:00
LICENSE.md Add LICENSE.md 2018-07-11 18:06:27 +02:00
Makefile Integrate further with ooni/probe-engine: episode two (#46) 2019-08-15 18:08:43 +02:00
ooni_test.go Basic ooni unittest 2018-09-17 11:52:42 +02:00
ooni.go Integrate further with ooni/probe-engine: episode two (#46) 2019-08-15 18:08:43 +02:00
Readme.md Use MK v0.10.x, zap legacy GeoIP, build also on Linux (#29) 2019-05-15 15:48:06 +03:00

OONI Probe CLI

The next generation OONI Probe Command Line Interface.

Development setup

Be sure you have golang >= 1.12. We use Go modules. Make sure you don't have GOPATH set.

Run

./build.sh help

to get information on the supported systems as well as to get instructions on how to install dependencies.