ooni-probe-cli/internal
Simone Basso 7cde93fca4
Make sure ooniprobe show <id> is WAI (#61)
1. the description of the command and the helper function are
clear hints that the command is intended to show a single JSON
measurement at a time (also the use case seems clear) [*]

2. the function used to read lines was failing for all my
measurements that take input. Since that was not the optimal
pattern anyway, use a better pattern to fix it.

3. some changes are automatically applied by my editor (VSCode
with the Go plugin) and I am fine with them.

4. while reading code, I also applied my preferred pattern
wrt whitespaces, i.e.: no whitespace inside functions, if a
function feels too long in this way, just break it.

Closes #57

[*] Even if we want to show many measurements at a time, which
does not seem needed, given the UI patterns, this functionality
won't be P0. What is P0 is to bless a new beta and give to
@sarathms binaries for all archs that support a basic `show`.
2019-10-03 11:18:07 +02:00
..
bindata Strip the trailing slash from the bouncer url 2018-09-26 15:35:17 +02:00
cli Make sure ooniprobe show <id> is WAI (#61) 2019-10-03 11:18:07 +02:00
crashreport Improve the presentation of the measurement listing from the CLI 2018-09-13 14:54:56 +02:00
database Make sure ooniprobe show <id> is WAI (#61) 2019-10-03 11:18:07 +02:00
enginex Upgrade to ooni/probe-engine@v0.1.1 (#60) 2019-10-03 09:43:25 +02:00
legacy Make path and homedir related logic more robust 2018-05-21 17:33:59 -07:00
log/handlers Implement the show command (#53) 2019-10-02 18:23:14 +02:00
onboard Improve the presentation of the measurement listing from the CLI 2018-09-13 14:54:56 +02:00
output Implement the show command (#53) 2019-10-02 18:23:14 +02:00
shutil Remove shutil tests 2019-05-15 18:13:34 +02:00
util Make sure ooniprobe show <id> is WAI (#61) 2019-10-03 11:18:07 +02:00