Simone Basso 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7cde93fca4 
							
						 
					 
					
						
						
							
							Make sure ooniprobe show <id> is WAI ( #61 )  
						
						... 
						
						
						
						1. the description of the command and the helper function are
clear hints that the command is intended to show a single JSON
measurement at a time (also the use case seems clear) [*]
2. the function used to read lines was failing for all my
measurements that take input. Since that was not the optimal
pattern anyway, use a better pattern to fix it.
3. some changes are automatically applied by my editor (VSCode
with the Go plugin) and I am fine with them.
4. while reading code, I also applied my preferred pattern
wrt whitespaces, i.e.: no whitespace inside functions, if a
function feels too long in this way, just break it.
Closes  #57 
[*] Even if we want to show many measurements at a time, which
does not seem needed, given the UI patterns, this functionality
won't be P0. What is P0 is to bless a new beta and give to
@sarathms binaries for all archs that support a basic `show`. 
						
						
					 
					
						2019-10-03 11:18:07 +02:00 
						 
				 
			
				
					
						
							
							
								Simone Basso 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							f3865d2ec0 
							
						 
					 
					
						
						
							
							Upgrade to ooni/probe-engine@v0.1.1 ( #60 )  
						
						
						
						
					 
					
						2019-10-03 09:43:25 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							f425d3f007 
							
						 
					 
					
						
						
							
							Implement the show command ( #53 )  
						
						
						
						
					 
					
						2019-10-02 18:23:14 +02:00 
						 
				 
			
				
					
						
							
							
								Simone Basso 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							df629237be 
							
						 
					 
					
						
						
							
							Use ooni/probe-engine: episode 1 ( #42 )  
						
						
						
						
					 
					
						2019-05-23 16:38:46 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							826822df31 
							
						 
					 
					
						
						
							
							Copy and delete instead of rename  
						
						... 
						
						
						
						Fixes: https://github.com/ooni/probe-cli/issues/21  
						
						
					 
					
						2019-05-15 18:06:09 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							8916ff8398 
							
						 
					 
					
						
						
							
							Add note about the testKeys extraction function  
						
						
						
						
					 
					
						2018-09-27 11:42:55 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							47a2fbb88c 
							
						 
					 
					
						
						
							
							Add rm command to delete results  
						
						
						
						
					 
					
						2018-09-18 09:54:27 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							aad8a395ed 
							
						 
					 
					
						
						
							
							Fix return value of database.Connect method  
						
						
						
						
					 
					
						2018-09-17 17:57:26 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							41f449d6c9 
							
						 
					 
					
						
						
							
							Remove debug log from unittests  
						
						
						
						
					 
					
						2018-09-17 17:35:57 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							18a89f4cbd 
							
						 
					 
					
						
						
							
							[schema-change] Prefix all columns that could cause conflicts  
						
						
						
						
					 
					
						2018-09-17 17:30:38 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							52bfe5df6c 
							
						 
					 
					
						
						
							
							Add support for deleting measurements  
						
						
						
						
					 
					
						2018-09-17 17:30:29 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							7f5df07782 
							
						 
					 
					
						
						
							
							Fix a very annoying logic bug in URL insertion  
						
						... 
						
						
						
						Write test case for it 
						
						
					 
					
						2018-09-12 18:47:57 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							b1ae8bc13e 
							
						 
					 
					
						
						
							
							Show data usage in summary of measurements  
						
						
						
						
					 
					
						2018-09-12 15:41:54 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							54af7170d4 
							
						 
					 
					
						
						
							
							Add support for data_usage event  
						
						
						
						
					 
					
						2018-09-12 13:42:16 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							2081c25b73 
							
						 
					 
					
						
						
							
							Expose the median_bitrate in the list view  
						
						
						
						
					 
					
						2018-09-11 18:41:15 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							0ee0c28129 
							
						 
					 
					
						
						
							
							Resolve country code ambigious selection  
						
						
						
						
					 
					
						2018-09-11 18:06:15 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							d02ed117f9 
							
						 
					 
					
						
						
							
							Include total_runtime in the summary of measurements  
						
						
						
						
					 
					
						2018-09-11 16:36:09 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							8da12a9c07 
							
						 
					 
					
						
						
							
							Add measurement summary to list command  
						
						
						
						
					 
					
						2018-09-11 15:40:42 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							31ccb1c181 
							
						 
					 
					
						
						
							
							Improvements to the list output  
						
						
						
						
					 
					
						2018-09-11 15:19:08 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							1637fdbf93 
							
						 
					 
					
						
						
							
							Structured output of measurements  
						
						
						
						
					 
					
						2018-09-10 18:03:32 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							e5c508a94c 
							
						 
					 
					
						
						
							
							Fix bug in result listing  
						
						
						
						
					 
					
						2018-09-10 16:56:32 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							e0c0acffeb 
							
						 
					 
					
						
						
							
							Make error reporting more robust to panic  
						
						
						
						
					 
					
						2018-09-10 16:29:14 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							898332064b 
							
						 
					 
					
						
						
							
							Add result testkeys projection  
						
						
						
						
					 
					
						2018-09-10 15:03:52 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							73fafacc2c 
							
						 
					 
					
						
						
							
							Zap unused method  
						
						
						
						
					 
					
						2018-09-10 12:53:43 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							b29071f37b 
							
						 
					 
					
						
						
							
							Replace summary with test_keys  
						
						
						
						
					 
					
						2018-09-10 12:41:28 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							ca505dfff3 
							
						 
					 
					
						
						
							
							Write a unittest for the URL creation function  
						
						
						
						
					 
					
						2018-09-07 15:29:16 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							6f0defc672 
							
						 
					 
					
						
						
							
							Refactor URL table row creation into the actions file  
						
						
						
						
					 
					
						2018-09-07 15:23:29 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							c2ea0c2a63 
							
						 
					 
					
						
						
							
							Fix List* workflows and add unittests for them  
						
						
						
						
					 
					
						2018-09-07 15:16:20 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							dabbdc15d2 
							
						 
					 
					
						
						
							
							Fix bug in the test creation workflow  
						
						
						
						
					 
					
						2018-09-07 14:06:08 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							35bd334cfc 
							
						 
					 
					
						
						
							
							Update the measurement, network and url creation to the new schema  
						
						
						
						
					 
					
						2018-09-07 12:55:27 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							b75cee5e84 
							
						 
					 
					
						
						
							
							Progress on schema and fixing unittests  
						
						
						
						
					 
					
						2018-09-06 16:13:04 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							a518ca79da 
							
						 
					 
					
						
						
							
							Fix DB schema, write a basic unittest for the DB operations  
						
						
						
						
					 
					
						2018-09-06 15:34:56 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							ff2f973523 
							
						 
					 
					
						
						
							
							Start integrating upper/db as a new ORM  
						
						
						
						
					 
					
						2018-09-05 18:40:37 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							cf588c8466 
							
						 
					 
					
						
						
							
							Move summary related code into it's own package  
						
						
						
						
					 
					
						2018-06-28 13:51:43 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							eb4e6988b3 
							
						 
					 
					
						
						
							
							Implement quick and dirty measurement listing  
						
						
						
						
					 
					
						2018-06-22 12:12:35 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							ecf3370f53 
							
						 
					 
					
						
						
							
							Implement result listing from CLI  
						
						... 
						
						
						
						Change the schema to include ASN and Network Name in the results table 
						
						
					 
					
						2018-05-03 18:40:52 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							0c5b6aa37c 
							
						 
					 
					
						
						
							
							Rename gooni to probe-cli  
						
						... 
						
						
						
						This is the command I used:
```
rg 'github.com/openobservatory/gooni' --files-with-matches \
    | xargs sed -i '' 's/github.com\/openobservatory\/gooni/github.com\/ooni\/probe-cli/g'
``` 
						
						
					 
					
						2018-05-03 14:59:55 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							cffb9ea74c 
							
						 
					 
					
						
						
							
							Move all directory related functionality into paths utils  
						
						... 
						
						
						
						As per suggestion by @willscott in: https://github.com/OpenObservatory/gooni/pull/9#discussion_r176760264  
						
						
					 
					
						2018-03-27 15:09:34 +02:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							98e95b8b7e 
							
						 
					 
					
						
						
							
							Add support for generating the web connectivity summary  
						
						
						
						
					 
					
						2018-03-23 14:58:33 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							f5ff3ac87a 
							
						 
					 
					
						
						
							
							Add support for generating the Measurement summary  
						
						... 
						
						
						
						To generate the result summary we need to refactor how the SummaryMap
works 
						
						
					 
					
						2018-03-23 13:17:39 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							7fe1551951 
							
						 
					 
					
						
						
							
							Refactor how we create the context  
						
						
						
						
					 
					
						2018-03-23 12:10:14 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							bd6c5b20d0 
							
						 
					 
					
						
						
							
							Minor style fixes  
						
						
						
						
					 
					
						2018-03-20 14:31:05 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							ce0e077175 
							
						 
					 
					
						
						
							
							Add hooks for generating result summaries  
						
						
						
						
					 
					
						2018-03-20 14:19:19 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							e0bb4000e9 
							
						 
					 
					
						
						
							
							Implement most of the measurement & result DB workflow  
						
						
						
						
					 
					
						2018-03-20 12:38:33 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							9f438ae068 
							
						 
					 
					
						
						
							
							Implement state tracking in database  
						
						
						
						
					 
					
						2018-03-19 19:28:32 +01:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							e2499dc4b0 
							
						 
					 
					
						
						
							
							Keep track of the measurement state in the database  
						
						
						
						
					 
					
						2018-03-19 16:23:30 +01:00 
						 
				 
			
				
					
						
							
							
								Will Scott 
							
						 
					 
					
						
						
						
						
							
						
						
							41e56f6a41 
							
						 
					 
					
						
						
							
							Merge branch 'master' of github.com:openobservatory/gooni  
						
						
						
						
					 
					
						2018-03-08 05:12:52 -08:00 
						 
				 
			
				
					
						
							
							
								Will Scott 
							
						 
					 
					
						
						
						
						
							
						
						
							90edffb1d7 
							
						 
					 
					
						
						
							
							ensure presence of home and home/db dir's during creation of the default config file  
						
						
						
						
					 
					
						2018-03-08 05:07:25 -08:00 
						 
				 
			
				
					
						
							
							
								Arturo Filastò 
							
						 
					 
					
						
						
						
						
							
						
						
							9cf8008c01 
							
						 
					 
					
						
						
							
							Fix MK integration  
						
						
						
						
					 
					
						2018-03-08 13:46:21 +01:00 
						 
				 
			
				
					
						
							
							
								Will Scott 
							
						 
					 
					
						
						
						
						
							
						
						
							7e9a4fc3b7 
							
						 
					 
					
						
						
							
							implement db update  
						
						
						
						
					 
					
						2018-03-08 02:53:04 -08:00