c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add note about the testKeys extraction function

Browse Source
This commit is contained in:
Arturo Filastò 2018-09-27 11:42:55 +02:00
parent 1879f8e961
commit 8916ff8398
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/database/actions.go
View File

@ -50,7 +50,12 @@ func GetResultTestKeys(sess sqlbuilder.Database, resultID int64) (string, error)
if msmt.TestName == "web_connectivity" {
break
}
// We only really care about performance keys
// We only really care about performance keys.
// Note: since even in case of failure we still initialise an empty struct,
// it could be that these keys come out as initializes with the default
// values.
// XXX we may want to change this behaviour by adding `omitempty` to the
// struct definition.
if msmt.TestName == "ndt" || msmt.TestName == "dash" {
if err := json.Unmarshal([]byte(msmt.TestKeys), &tk); err != nil {
log.WithError(err).Error("failed to parse testKeys")