c/ooni-probe-cli
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: link new TODOs with the relevant issues (#321)

Browse Source 
Part of https://github.com/ooni/probe/issues/985
This commit is contained in:
Simone Basso 2021-04-29 18:43:31 +02:00 committed by GitHub
parent 1d70b81187
commit 9d5a3321af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/engine/experiment/riseupvpn/riseupvpn.go
View File

@ -259,6 +259,7 @@ func (m Measurer) Run(ctx context.Context, sess model.ExperimentSession,
// measure obfs4 in parallel // measure obfs4 in parallel
// TODO(bassosimone): when urlgetter is able to do obfs4 handshakes, here // TODO(bassosimone): when urlgetter is able to do obfs4 handshakes, here
// can possibly also test for the obfs4 handshake. // can possibly also test for the obfs4 handshake.
// See https://github.com/ooni/probe/issues/1463.
for entry := range multi.CollectOverall( for entry := range multi.CollectOverall(
ctx, obfs4Endpoints, 1+len(inputs)+len(openvpnEndpoints), overallCount, "riseupvpn", callbacks) { ctx, obfs4Endpoints, 1+len(inputs)+len(openvpnEndpoints), overallCount, "riseupvpn", callbacks) {
testkeys.AddGatewayConnectTestKeys(entry, "obfs4") testkeys.AddGatewayConnectTestKeys(entry, "obfs4")

1
pkg/oonimkall/internal/tasks/runner.go
View File

@ -77,6 +77,7 @@ func (r *Runner) newsession(ctx context.Context, logger *ChanLogger) (*engine.Se
} }
// TODO(bassosimone): write tests for this functionality // TODO(bassosimone): write tests for this functionality
// See https://github.com/ooni/probe/issues/1465.
var proxyURL *url.URL var proxyURL *url.URL
if r.settings.Proxy != "" { if r.settings.Proxy != "" {
var err error var err error

1
pkg/oonimkall/session.go
View File

@ -169,6 +169,7 @@ func newSessionWithContext(ctx context.Context, config *SessionConfig) (*Session
} }
// TODO(bassosimone): write tests for this functionality. // TODO(bassosimone): write tests for this functionality.
// See https://github.com/ooni/probe/issues/1465.
var proxyURL *url.URL var proxyURL *url.URL
if config.Proxy != "" { if config.Proxy != "" {
var err error var err error