From 9d5a3321af4127ccb46b5b63568d36565c15562c Mon Sep 17 00:00:00 2001 From: Simone Basso Date: Thu, 29 Apr 2021 18:43:31 +0200 Subject: [PATCH] chore: link new TODOs with the relevant issues (#321) Part of https://github.com/ooni/probe/issues/985 --- internal/engine/experiment/riseupvpn/riseupvpn.go | 1 + pkg/oonimkall/internal/tasks/runner.go | 1 + pkg/oonimkall/session.go | 1 + 3 files changed, 3 insertions(+) diff --git a/internal/engine/experiment/riseupvpn/riseupvpn.go b/internal/engine/experiment/riseupvpn/riseupvpn.go index 3f27c8c..34c1e75 100644 --- a/internal/engine/experiment/riseupvpn/riseupvpn.go +++ b/internal/engine/experiment/riseupvpn/riseupvpn.go @@ -259,6 +259,7 @@ func (m Measurer) Run(ctx context.Context, sess model.ExperimentSession, // measure obfs4 in parallel // TODO(bassosimone): when urlgetter is able to do obfs4 handshakes, here // can possibly also test for the obfs4 handshake. + // See https://github.com/ooni/probe/issues/1463. for entry := range multi.CollectOverall( ctx, obfs4Endpoints, 1+len(inputs)+len(openvpnEndpoints), overallCount, "riseupvpn", callbacks) { testkeys.AddGatewayConnectTestKeys(entry, "obfs4") diff --git a/pkg/oonimkall/internal/tasks/runner.go b/pkg/oonimkall/internal/tasks/runner.go index ebc01df..ebff330 100644 --- a/pkg/oonimkall/internal/tasks/runner.go +++ b/pkg/oonimkall/internal/tasks/runner.go @@ -77,6 +77,7 @@ func (r *Runner) newsession(ctx context.Context, logger *ChanLogger) (*engine.Se } // TODO(bassosimone): write tests for this functionality + // See https://github.com/ooni/probe/issues/1465. var proxyURL *url.URL if r.settings.Proxy != "" { var err error diff --git a/pkg/oonimkall/session.go b/pkg/oonimkall/session.go index 7706434..059abae 100644 --- a/pkg/oonimkall/session.go +++ b/pkg/oonimkall/session.go @@ -169,6 +169,7 @@ func newSessionWithContext(ctx context.Context, config *SessionConfig) (*Session } // TODO(bassosimone): write tests for this functionality. + // See https://github.com/ooni/probe/issues/1465. var proxyURL *url.URL if config.Proxy != "" { var err error