Make sure ooniprobe show <id> is WAI (#61)

1. the description of the command and the helper function are
clear hints that the command is intended to show a single JSON
measurement at a time (also the use case seems clear) [*]

2. the function used to read lines was failing for all my
measurements that take input. Since that was not the optimal
pattern anyway, use a better pattern to fix it.

3. some changes are automatically applied by my editor (VSCode
with the Go plugin) and I am fine with them.

4. while reading code, I also applied my preferred pattern
wrt whitespaces, i.e.: no whitespace inside functions, if a
function feels too long in this way, just break it.

Closes #57

[*] Even if we want to show many measurements at a time, which
does not seem needed, given the UI patterns, this functionality
won't be P0. What is P0 is to bless a new beta and give to
@sarathms binaries for all archs that support a basic `show`.

internal/cli/list/list.go

@@ -10,9 +10,7 @@ import (
 
 func init() {
 	cmd := root.Command("list", "List results")
-
 	resultID := cmd.Arg("id", "the id of the result to list measurements for").Int64()
-
 	cmd.Action(func(_ *kingpin.ParseContext) error {
 		ctx, err := root.Init()
 		if err != nil {
@@ -25,7 +23,6 @@ func init() {
 				log.WithError(err).Error("failed to list measurements")
 				return err
 			}
-
 			msmtSummary := output.MeasurementSummaryData{
 				TotalCount:         0,
 				AnomalyCount:       0,
@@ -45,7 +42,6 @@ func init() {
 				if idx == len(measurements)-1 {
 					isLast = true
 				}
-
 				// We assume that since these are summary level information the first
 				// item will contain the information necessary.
 				if isFirst {
@@ -70,7 +66,6 @@ func init() {
 				log.WithError(err).Error("failed to list results")
 				return err
 			}
-
 			if len(incompleteResults) > 0 {
 				output.SectionTitle("Incomplete results")
 			}
@@ -92,7 +87,6 @@ func init() {
 					DataUsageDown:           result.DataUsageDown,
 				})
 			}
-
 			resultSummary := output.ResultSummaryData{}
 			netCount := make(map[uint]int)
 			output.SectionTitle("Results")
@@ -117,9 +111,9 @@ func init() {
 					TestKeys:                testKeys,
 					MeasurementCount:        totalCount,
 					MeasurementAnomalyCount: anmlyCount,
-					Done:          result.IsDone,
-					DataUsageUp:   result.DataUsageUp,
-					DataUsageDown: result.DataUsageDown,
+					Done:                    result.IsDone,
+					DataUsageUp:             result.DataUsageUp,
+					DataUsageDown:           result.DataUsageDown,
 				})
 				resultSummary.TotalTests++
 				netCount[result.Network.ASN]++
@@ -127,10 +121,8 @@ func init() {
 				resultSummary.TotalDataUsageDown += result.DataUsageDown
 			}
 			resultSummary.TotalNetworks = int64(len(netCount))
-
 			output.ResultSummary(resultSummary)
 		}
-
 		return nil
 	})
 }

internal/cli/show/show.go

@@ -10,9 +10,7 @@ import (
 
 func init() {
 	cmd := root.Command("show", "Show a specific measurement")
-
-	msmtID := cmd.Arg("id", "the id of the measurement to show").Int64()
-
+	msmtID := cmd.Arg("id", "the id of the measurement to show").Required().Int64()
 	cmd.Action(func(_ *kingpin.ParseContext) error {
 		ctx, err := root.Init()
 		if err != nil {