cenochallenge/ReadYou
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix initial filter (#229)

Browse Source
This commit is contained in:
Ashinch 2022-10-08 21:19:43 +08:00 committed by GitHub
parent 352fe36980
commit d948e15fc7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
app/src/main/java/me/ash/reader/ui/page/home/flow/FlowPage.kt
View File

@ -129,7 +129,12 @@ fun FlowPage(
}, },
) { ) {
scope.launch { scope.launch {
flowUiState.listState.scrollToItem(0) // java.lang.NullPointerException: Attempt to invoke virtual method
// 'boolean androidx.compose.ui.node.LayoutNode.getNeedsOnPositionedDispatch$ui_release()'
// on a null object reference
if (flowUiState.listState.firstVisibleItemIndex != 0) {
flowUiState.listState.scrollToItem(0)
}
markAsRead = !markAsRead markAsRead = !markAsRead
onSearch = false onSearch = false
} }
@ -145,7 +150,12 @@ fun FlowPage(
}, },
) { ) {
scope.launch { scope.launch {
flowUiState.listState.scrollToItem(0) // java.lang.NullPointerException: Attempt to invoke virtual method
// 'boolean androidx.compose.ui.node.LayoutNode.getNeedsOnPositionedDispatch$ui_release()'
// on a null object reference
if (flowUiState.listState.firstVisibleItemIndex != 0) {
flowUiState.listState.scrollToItem(0)
}
onSearch = !onSearch onSearch = !onSearch
} }
} }
@ -249,7 +259,14 @@ fun FlowPage(
filterBarPadding = filterBarPadding.dp, filterBarPadding = filterBarPadding.dp,
filterBarTonalElevation = filterBarTonalElevation.value.dp, filterBarTonalElevation = filterBarTonalElevation.value.dp,
) { ) {
flowViewModel.scrollToItem(0) scope.launch {
// java.lang.NullPointerException: Attempt to invoke virtual method
// 'boolean androidx.compose.ui.node.LayoutNode.getNeedsOnPositionedDispatch$ui_release()'
// on a null object reference
if (flowUiState.listState.firstVisibleItemIndex != 0) {
flowUiState.listState.scrollToItem(0)
}
}
homeViewModel.changeFilter(filterUiState.copy(filter = it)) homeViewModel.changeFilter(filterUiState.copy(filter = it))
homeViewModel.fetchArticles() homeViewModel.fetchArticles()
} }

6
app/src/main/java/me/ash/reader/ui/page/home/flow/FlowViewModel.kt
View File

@ -30,12 +30,6 @@ class FlowViewModel @Inject constructor(
} }
} }
fun scrollToItem(index: Int) {
viewModelScope.launch {
_flowUiState.value.listState.scrollToItem(index)
}
}
fun markAsRead( fun markAsRead(
groupId: String?, groupId: String?,
feedId: String?, feedId: String?,