273b70bacc
## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: https://github.com/ooni/probe/issues/1885 - [x] related ooni/spec pull request: N/A Location of the issue tracker: https://github.com/ooni/probe ## Description This PR contains a set of changes to move important interfaces and data types into the `./internal/model` package. The criteria for including an interface or data type in here is roughly that the type should be important and used by several packages. We are especially interested to move more interfaces here to increase modularity. An additional side effect is that, by reading this package, one should be able to understand more quickly how different parts of the codebase interact with each other. This is what I want to move in `internal/model`: - [x] most important interfaces from `internal/netxlite` - [x] everything that was previously part of `internal/engine/model` - [x] mocks from `internal/netxlite/mocks` should also be moved in here as a subpackage
94 lines
2.1 KiB
Go
94 lines
2.1 KiB
Go
package engine
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/apex/log"
|
|
"github.com/ooni/probe-cli/v3/internal/atomicx"
|
|
"github.com/ooni/probe-cli/v3/internal/model"
|
|
)
|
|
|
|
func TestSubmitterNotEnabled(t *testing.T) {
|
|
ctx := context.Background()
|
|
submitter, err := NewSubmitter(ctx, SubmitterConfig{
|
|
Enabled: false,
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, ok := submitter.(stubSubmitter); !ok {
|
|
t.Fatal("we did not get a stubSubmitter instance")
|
|
}
|
|
m := new(model.Measurement)
|
|
if err := submitter.Submit(ctx, m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
type FakeSubmitter struct {
|
|
Calls *atomicx.Int64
|
|
Error error
|
|
}
|
|
|
|
func (fs *FakeSubmitter) Submit(ctx context.Context, m *model.Measurement) error {
|
|
if fs.Calls != nil {
|
|
fs.Calls.Add(1)
|
|
}
|
|
return fs.Error
|
|
}
|
|
|
|
var _ Submitter = &FakeSubmitter{}
|
|
|
|
type FakeSubmitterSession struct {
|
|
Error error
|
|
Submitter Submitter
|
|
}
|
|
|
|
func (fse FakeSubmitterSession) NewSubmitter(ctx context.Context) (Submitter, error) {
|
|
return fse.Submitter, fse.Error
|
|
}
|
|
|
|
var _ SubmitterSession = FakeSubmitterSession{}
|
|
|
|
func TestNewSubmitterFails(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
ctx := context.Background()
|
|
submitter, err := NewSubmitter(ctx, SubmitterConfig{
|
|
Enabled: true,
|
|
Session: FakeSubmitterSession{Error: expected},
|
|
})
|
|
if !errors.Is(err, expected) {
|
|
t.Fatalf("not the error we expected: %+v", err)
|
|
}
|
|
if submitter != nil {
|
|
t.Fatal("expected nil submitter here")
|
|
}
|
|
}
|
|
|
|
func TestNewSubmitterWithFailedSubmission(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
ctx := context.Background()
|
|
fakeSubmitter := &FakeSubmitter{
|
|
Calls: &atomicx.Int64{},
|
|
Error: expected,
|
|
}
|
|
submitter, err := NewSubmitter(ctx, SubmitterConfig{
|
|
Enabled: true,
|
|
Logger: log.Log,
|
|
Session: FakeSubmitterSession{Submitter: fakeSubmitter},
|
|
})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
m := new(model.Measurement)
|
|
err = submitter.Submit(context.Background(), m)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatalf("not the error we expected: %+v", err)
|
|
}
|
|
if fakeSubmitter.Calls.Load() != 1 {
|
|
t.Fatal("unexpected number of calls")
|
|
}
|
|
}
|