83440cf110
The legacy part for now is internal/errorsx. It will stay there until I figure out whether it also needs some extra bug fixing. The good part is now in internal/netxlite/errorsx and contains all the logic for mapping errors. We need to further improve upon this logic by writing more thorough integration tests for QUIC. We also need to copy the various dialer, conn, etc adapters that set errors. We will put them inside netxlite and we will generate errors in a way that is less crazy with respect to the major operation. (The idea is to always wrap, given that now we measure in an incremental way and we don't measure every operation together.) Part of https://github.com/ooni/probe/issues/1591
390 lines
9.8 KiB
Go
390 lines
9.8 KiB
Go
package oonitemplates
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"net"
|
|
"strings"
|
|
"sync"
|
|
"testing"
|
|
"time"
|
|
|
|
goptlib "git.torproject.org/pluggable-transports/goptlib.git"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/legacy/netx/modelx"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite/errorsx"
|
|
"gitlab.com/yawning/obfs4.git/transports"
|
|
obfs4base "gitlab.com/yawning/obfs4.git/transports/base"
|
|
)
|
|
|
|
func TestChannelHandlerWriteLateOnChannel(t *testing.T) {
|
|
handler := newChannelHandler(make(chan modelx.Measurement))
|
|
var waitgroup sync.WaitGroup
|
|
waitgroup.Add(1)
|
|
go func() {
|
|
time.Sleep(1 * time.Second)
|
|
handler.OnMeasurement(modelx.Measurement{})
|
|
waitgroup.Done()
|
|
}()
|
|
waitgroup.Wait()
|
|
if handler.lateWrites.Load() != 1 {
|
|
t.Fatal("unexpected lateWrites value")
|
|
}
|
|
}
|
|
|
|
func TestDNSLookupGood(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := DNSLookup(ctx, DNSLookupConfig{
|
|
Hostname: "ooni.io",
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
if len(results.Addresses) < 1 {
|
|
t.Fatal("no addresses returned?!")
|
|
}
|
|
}
|
|
|
|
func TestDNSLookupCancellation(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(
|
|
context.Background(), time.Microsecond,
|
|
)
|
|
defer cancel()
|
|
results := DNSLookup(ctx, DNSLookupConfig{
|
|
Hostname: "ooni.io",
|
|
})
|
|
if results.Error == nil {
|
|
t.Fatal("expected an error here")
|
|
}
|
|
if results.Error.Error() != errorsx.FailureGenericTimeoutError {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if len(results.Addresses) > 0 {
|
|
t.Fatal("addresses returned?!")
|
|
}
|
|
}
|
|
|
|
func TestDNSLookupUnknownDNS(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := DNSLookup(ctx, DNSLookupConfig{
|
|
Hostname: "ooni.io",
|
|
ServerNetwork: "antani",
|
|
})
|
|
if !strings.HasSuffix(results.Error.Error(), "unsupported network value") {
|
|
t.Fatal("expected a different error here")
|
|
}
|
|
}
|
|
|
|
func TestHTTPDoGood(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := HTTPDo(ctx, HTTPDoConfig{
|
|
Accept: "*/*",
|
|
AcceptLanguage: "en",
|
|
URL: "http://ooni.io",
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
if results.StatusCode != 200 {
|
|
t.Fatal("request failed?!")
|
|
}
|
|
if len(results.Headers) < 1 {
|
|
t.Fatal("no headers?!")
|
|
}
|
|
if len(results.BodySnap) < 1 {
|
|
t.Fatal("no body?!")
|
|
}
|
|
}
|
|
|
|
func TestHTTPDoUnknownDNS(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := HTTPDo(ctx, HTTPDoConfig{
|
|
URL: "http://ooni.io",
|
|
DNSServerNetwork: "antani",
|
|
})
|
|
if !strings.HasSuffix(results.Error.Error(), "unsupported network value") {
|
|
t.Fatal("not the error that we expected")
|
|
}
|
|
}
|
|
|
|
func TestHTTPDoForceSkipVerify(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := HTTPDo(ctx, HTTPDoConfig{
|
|
URL: "https://self-signed.badssl.com/",
|
|
InsecureSkipVerify: true,
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestHTTPDoRoundTripError(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := HTTPDo(ctx, HTTPDoConfig{
|
|
URL: "http://ooni.io:443", // 443 with http
|
|
})
|
|
if results.Error == nil {
|
|
t.Fatal("expected an error here")
|
|
}
|
|
}
|
|
|
|
func TestHTTPDoBadURL(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := HTTPDo(ctx, HTTPDoConfig{
|
|
URL: "\t",
|
|
})
|
|
if !strings.HasSuffix(results.Error.Error(), "invalid control character in URL") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestTLSConnectGood(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TLSConnect(ctx, TLSConnectConfig{
|
|
Address: "ooni.io:443",
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestTLSConnectGoodWithDoT(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TLSConnect(ctx, TLSConnectConfig{
|
|
Address: "ooni.io:443",
|
|
DNSServerNetwork: "dot",
|
|
DNSServerAddress: "9.9.9.9:853",
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestTLSConnectCancellation(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(
|
|
context.Background(), time.Microsecond,
|
|
)
|
|
defer cancel()
|
|
results := TLSConnect(ctx, TLSConnectConfig{
|
|
Address: "ooni.io:443",
|
|
})
|
|
if results.Error == nil {
|
|
t.Fatal("expected an error here")
|
|
}
|
|
if results.Error.Error() != errorsx.FailureGenericTimeoutError {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestTLSConnectUnknownDNS(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TLSConnect(ctx, TLSConnectConfig{
|
|
Address: "ooni.io:443",
|
|
DNSServerNetwork: "antani",
|
|
})
|
|
if !strings.HasSuffix(results.Error.Error(), "unsupported network value") {
|
|
t.Fatal("not the error that we expected")
|
|
}
|
|
}
|
|
|
|
func TestTLSConnectForceSkipVerify(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TLSConnect(ctx, TLSConnectConfig{
|
|
Address: "self-signed.badssl.com:443",
|
|
InsecureSkipVerify: true,
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestBodySnapSizes(t *testing.T) {
|
|
const (
|
|
maxEventsBodySnapSize = 1 << 7
|
|
maxResponseBodySnapSize = 1 << 8
|
|
)
|
|
ctx := context.Background()
|
|
results := HTTPDo(ctx, HTTPDoConfig{
|
|
URL: "https://ooni.org",
|
|
MaxEventsBodySnapSize: maxEventsBodySnapSize,
|
|
MaxResponseBodySnapSize: maxResponseBodySnapSize,
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
if results.StatusCode != 200 {
|
|
t.Fatal("request failed?!")
|
|
}
|
|
if len(results.Headers) < 1 {
|
|
t.Fatal("no headers?!")
|
|
}
|
|
if len(results.BodySnap) != maxResponseBodySnapSize {
|
|
t.Fatal("invalid response body snap size")
|
|
}
|
|
if results.TestKeys.HTTPRequests == nil {
|
|
t.Fatal("no HTTPRequests?!")
|
|
}
|
|
for _, req := range results.TestKeys.HTTPRequests {
|
|
if len(req.ResponseBodySnap) != maxEventsBodySnapSize {
|
|
t.Fatal("invalid length of ResponseBodySnap")
|
|
}
|
|
if req.MaxBodySnapSize != maxEventsBodySnapSize {
|
|
t.Fatal("unexpected value of MaxBodySnapSize")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestTCPConnectGood(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TCPConnect(ctx, TCPConnectConfig{
|
|
Address: "ooni.io:443",
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestTCPConnectGoodWithDoT(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TCPConnect(ctx, TCPConnectConfig{
|
|
Address: "ooni.io:443",
|
|
DNSServerNetwork: "dot",
|
|
DNSServerAddress: "9.9.9.9:853",
|
|
})
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestTCPConnectUnknownDNS(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := TCPConnect(ctx, TCPConnectConfig{
|
|
Address: "ooni.io:443",
|
|
DNSServerNetwork: "antani",
|
|
})
|
|
if !strings.HasSuffix(results.Error.Error(), "unsupported network value") {
|
|
t.Fatal("not the error that we expected")
|
|
}
|
|
}
|
|
|
|
func obfs4config() OBFS4ConnectConfig {
|
|
// TODO(bassosimone): this is a public working bridge we have found
|
|
// with @hellais. We should ask @phw whether there is some obfs4 bridge
|
|
// dedicated to integration testing that we should use instead.
|
|
return OBFS4ConnectConfig{
|
|
Address: "109.105.109.165:10527",
|
|
StateBaseDir: "../../testdata/",
|
|
Params: map[string][]string{
|
|
"cert": {
|
|
"Bvg/itxeL4TWKLP6N1MaQzSOC6tcRIBv6q57DYAZc3b2AzuM+/TfB7mqTFEfXILCjEwzVA",
|
|
},
|
|
"iat-mode": {"1"},
|
|
},
|
|
}
|
|
}
|
|
|
|
func TestOBFS4ConnectGood(t *testing.T) {
|
|
ctx := context.Background()
|
|
results := OBFS4Connect(ctx, obfs4config())
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestOBFS4ConnectGoodWithDoT(t *testing.T) {
|
|
ctx := context.Background()
|
|
config := obfs4config()
|
|
config.DNSServerNetwork = "dot"
|
|
config.DNSServerAddress = "9.9.9.9:853"
|
|
results := OBFS4Connect(ctx, config)
|
|
if results.Error != nil {
|
|
t.Fatal(results.Error)
|
|
}
|
|
}
|
|
|
|
func TestOBFS4ConnectUnknownDNS(t *testing.T) {
|
|
ctx := context.Background()
|
|
config := obfs4config()
|
|
config.DNSServerNetwork = "antani"
|
|
results := OBFS4Connect(ctx, config)
|
|
if !strings.HasSuffix(results.Error.Error(), "unsupported network value") {
|
|
t.Fatal("not the error that we expected")
|
|
}
|
|
}
|
|
|
|
func TestOBFS4IoutilTempDirError(t *testing.T) {
|
|
ctx := context.Background()
|
|
config := obfs4config()
|
|
expected := errors.New("mocked error")
|
|
config.ioutilTempDir = func(dir, prefix string) (string, error) {
|
|
return "", expected
|
|
}
|
|
results := OBFS4Connect(ctx, config)
|
|
if !errors.Is(results.Error, expected) {
|
|
t.Fatal("not the error that we expected")
|
|
}
|
|
}
|
|
|
|
func TestOBFS4ClientFactoryError(t *testing.T) {
|
|
ctx := context.Background()
|
|
config := obfs4config()
|
|
config.transportsGet = func(name string) obfs4base.Transport {
|
|
txp := transports.Get(name)
|
|
if name == "obfs4" && txp != nil {
|
|
txp = &faketransport{txp: txp}
|
|
}
|
|
return txp
|
|
}
|
|
results := OBFS4Connect(ctx, config)
|
|
if results.Error.Error() != "mocked ClientFactory error" {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestOBFS4ParseArgsError(t *testing.T) {
|
|
ctx := context.Background()
|
|
config := obfs4config()
|
|
config.Params = make(map[string][]string) // cause ParseArgs error
|
|
results := OBFS4Connect(ctx, config)
|
|
if results.Error.Error() != "missing argument 'node-id'" {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestOBFS4DialContextError(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel() // should cause DialContex to fail
|
|
config := obfs4config()
|
|
results := OBFS4Connect(ctx, config)
|
|
if results.Error.Error() != "interrupted" {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestOBFS4SetDeadlineError(t *testing.T) {
|
|
ctx := context.Background()
|
|
config := obfs4config()
|
|
config.setDeadline = func(net.Conn, time.Time) error {
|
|
return errors.New("mocked error")
|
|
}
|
|
results := OBFS4Connect(ctx, config)
|
|
if !strings.HasSuffix(results.Error.Error(), "mocked error") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
type faketransport struct {
|
|
txp obfs4base.Transport
|
|
}
|
|
|
|
func (txp *faketransport) Name() string {
|
|
return txp.txp.Name()
|
|
}
|
|
|
|
func (txp *faketransport) ClientFactory(stateDir string) (obfs4base.ClientFactory, error) {
|
|
return nil, errors.New("mocked ClientFactory error")
|
|
}
|
|
|
|
func (txp *faketransport) ServerFactory(stateDir string, args *goptlib.Args) (obfs4base.ServerFactory, error) {
|
|
return txp.txp.ServerFactory(stateDir, args)
|
|
}
|