eed51978ca
As mentioned in https://github.com/ooni/probe/issues/1951, one of the main issues I did see with httpx.APIClient is that in some cases it's used in a very fragile way by probeservices.Client. This happens in psiphon.go and tor.go, where we create a copy of the APIClient and then modify it's Authorization field. If we ever refactor probeservices.Client to take a pointer to httpx.Client, we are now mutating the httpx.Client. Of course, we don't want that to happen. This diff attempts to address such a problem as follows: 1. we create a new APIClientTemplate type that holds the same fields of an APIClient and allows to build an APIClient 2. we modify every user of APIClient to use APIClientTemplate 3. when we need an APIClient, we build it from the corresponding template and, when we need to use a specific Authorization, we use a build factory that sets APIClient.Authorization 4. we hide APIClient by renaming it apiClient and by defining an interface called APIClient that allows to use it So, now the codebase always uses the opaque APIClient interface to issue API calls and always uses the APIClientTemplate to build an opaque APIClient. Boom! We have separated construction from usage and we are not mutating in weird ways the APIClient anymore. |
||
|---|---|---|
| .. | ||
| apitool | ||
| e2epostprocess | ||
| getresources | ||
| jafar | ||
| miniooni | ||
| oohelper | ||
| oohelperd | ||
| printversion | ||
| ptxclient | ||
| README.md | ||
Directory github.com/ooni/probe-cli/internal/cmd
This directory contains the source code for the CLI tools we build but we don't want to expose to the outside world. That is, you can only build these tools if you have cloned this repo.