c74c94d616
We are not using them anymore. The only nettest still using the legacy netx implementation is tor, for which setting these fields is useless, because it performs each measurement into a separate goroutine. Hence, let us start removing this part of the legacy netx codebase, which is hampering progress in other areas. Occurred to me while doing testing for the recent changes in error mapping (https://github.com/ooni/probe/issues/1505).
46 lines
1.1 KiB
Go
46 lines
1.1 KiB
Go
package resolver_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/ooni/probe-cli/v3/internal/engine/netx/errorx"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/netx/resolver"
|
|
)
|
|
|
|
func TestErrorWrapperSuccess(t *testing.T) {
|
|
orig := []string{"8.8.8.8"}
|
|
r := resolver.ErrorWrapperResolver{
|
|
Resolver: resolver.NewFakeResolverWithResult(orig),
|
|
}
|
|
addrs, err := r.LookupHost(context.Background(), "dns.google.com")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(addrs) != len(orig) || addrs[0] != orig[0] {
|
|
t.Fatal("not the result we expected")
|
|
}
|
|
}
|
|
|
|
func TestErrorWrapperFailure(t *testing.T) {
|
|
r := resolver.ErrorWrapperResolver{
|
|
Resolver: resolver.NewFakeResolverThatFails(),
|
|
}
|
|
ctx := context.Background()
|
|
addrs, err := r.LookupHost(ctx, "dns.google.com")
|
|
if addrs != nil {
|
|
t.Fatal("expected nil addr here")
|
|
}
|
|
var errWrapper *errorx.ErrWrapper
|
|
if !errors.As(err, &errWrapper) {
|
|
t.Fatal("cannot properly cast the returned error")
|
|
}
|
|
if errWrapper.Failure != errorx.FailureDNSNXDOMAINError {
|
|
t.Fatal("unexpected failure")
|
|
}
|
|
if errWrapper.Operation != errorx.ResolveOperation {
|
|
t.Fatal("unexpected Operation")
|
|
}
|
|
}
|