c2ea0b4704
We introduce a fork of internal/httpx, named internal/httpapi, where there is a clear split between the concept of an API endpoint (such as https://0.th.ooni.org/) and of an API descriptor (such as using `GET` to access /api/v1/test-list/url). Additionally, httpapi allows to create a SequenceCaller that tries to call a given API descriptor using multiple API endpoints. The SequenceCaller will stop once an endpoint works or when all the available endpoints have been tried unsuccessfully. The definition of "success" is the following: we consider "failure" any error that occurs during the HTTP round trip or when reading the response body. We DO NOT consider "failure" errors (1) when parsing the input URL; (2) when the server returns >= 400; (3) when the server returns a string that does not parse as valid JSON. The idea of this classification of failures is that we ONLY want to retry when we see what looks like a network error that may be caused by (collateral or targeted) censorship. We take advantage of the availability of this new package and we refactor web_connectivity@v0.4 and web_connectivity@v0.5 to use a SequenceCaller for calling the web connectivity TH API. This means that we will now try all the available THs advertised by the backend rather than just selecting and using the first one provided by the backend. Because this diff is designed to be backported to the `release/3.16` branch, we have omitted additional changes to always use httpapi where we are currently using httpx. Yet, to remind ourselves about the need to do that, we have deprecated the httpx package. We will rewrite all the code currently using httpx to use httpapi as part of future work. It is also worth noting that httpapi will allow us to refactor the backend code such that (1) we remove code to select a backend URL endpoint at the beginning and (2) we try several endpoints. The design of the code is such that we can add to the mix some endpoints using as `http.Client` a special client using a tunnel. This will allow us to automatically fallback backend queries. Closes https://github.com/ooni/probe/issues/2353. Related to https://github.com/ooni/probe/issues/1519. |
||
---|---|---|
.. | ||
analysiscore.go | ||
analysisdns.go | ||
analysishttpcore.go | ||
analysishttpdiff.go | ||
analysistcpip.go | ||
analysistls.go | ||
cleartextflow.go | ||
config.go | ||
control.go | ||
dnscache.go | ||
dnsresolvers.go | ||
dnswhoami.go | ||
doc.go | ||
inputparser.go | ||
iox.go | ||
measurer.go | ||
priority.go | ||
README.md | ||
redirects.go | ||
secureflow.go | ||
summary.go | ||
testkeys.go |
webconnectivity
This directory contains a new implementation of Web Connectivity.
As of 2022-09-15, this code is experimental and is not selected
by default when you run the websites
group. You can select this
implementation with miniooni
using miniooni web_connectivity@v0.5
from the command line.
Issue #2237 explains the rationale behind writing this new implementation.
Implementation overview
graph TD;
measurer.go --> dnsresolvers.go;
dnsresolvers.go --> control.go;
dnsresolvers.go --> cleartext.go;
dnsresolvers.go --> secure.go;
control.go --> cleartext.go;
control.go --> secure.go;
cleartext.go --> dnsresolvers.go;
secure.go --> dnsresolvers.go;
measurer.go --> analysiscore.go;
Figure I. Relationship between files in this implementation
The experiment measures a single URL at a time. The OONI Engine invokes the
Run
method inside the measurer.go file.
The first task that Run
starts deals with DNS and lives in the
dnsresolvers.go file. This task is responsible for
resolving the domain inside the URL into 0..N
IP addresses.
The domain resolution includes the system resolver and a DNS-over-UDP
resolver. The implementaion may do more than that, but this is the
bare minimum we're feeling like documenting right now. (We need to
experiment a bit more to understand what else we can do there, hence
the code is probably doing more than just that.)
Once we know the 0..N
IP addresses for the domain we do the following:
-
start a background task to communicate with the Web Connectivity test helper, using code inside control.go;
-
start an endpoint measurement task for each IP adddress (which of course only happens when we know at least one addr).
Regarding starting endpoint measurements, we follow this policy:
-
if the original URL is
http://...
then, for each address, we start an HTTP task using port80
and an HTTPS task using443
. -
if it's
https://...
, then we only start HTTPS tasks.
HTTP tasks are implemented by cleartextflow.go while the HTTPS tasks live in secureflow.go.
An HTTP task does the following:
-
TCP connect;
-
additionally, the first task to establish a connection also performs a GET request to fetch a webpage (we cannot GET for all connections, because that would be
websteps
and would require a different data format).
An HTTPS task does the following:
-
TCP connect;
-
TLS handshake;
-
additionally, the first task to handshake also performs a GET request to fetch a webpage iff the input URL was
https://...
(we cannot GET for all connections, because that would bewebsteps
and would require a different data format).
If fetching the webpage returns a redirect, we start a new DNS task passing it the redirect URL as the new URL to measure, thus transferring the control again to dnsresolvers.go. We do not call the test helper again when this happens, though. The Web Connectivity test helper already follows the whole redirect chain, so we would need to change the test helper to get information on each flow. If we fetched more than one webpage per redirect chain, this experiment would be websteps.
Additionally, when the test helper terminates, control.go may run HTTP and/or HTTPS tasks (when applicable) for new IP addresses discovered using the test helper that were previously unknown to the probe, thus collecting extra information.
When several connections are racing to fetch a webpage, we need specific logic to choose which of them to give the permission to actually fetch the webpage. This logic lives inside the priority.go file.
When all tasks complete, either because we reach a final state or because we have
followed too many redirects, we use code inside analysiscore.go to compute the
top-level test keys. We emit the blocking
and accessible
keys we emitted before
as well as new keys, prefixed by x_
to indicate that they're experimental.
Limitations and next steps
Further changes are probably possible. Departing too radically from the Web
Connectivity model, though, will lead us to have a websteps
implementation (but
then the data model would most likely be different).