ooni-probe-cli/internal/engine
Simone Basso bf3c8bcdc3
[forwardport] fix(netx): stop collecting HTTP performance metrics (#689)
This diff forward ports b6db4f64dc83a2a27ee3ce6bba5ac93db922832d, whose
original log message is the following:

- - -

We're now using ooni/oohttp as our HTTP library in most cases.

A limitation of this library is that net/http/httptrace does not
work very well and reliably because (1) we need to use oohttp's
version of that code and (2) we cannot observe net events.

I noticed this fact because an integration test for collecting
HTTP performance metrics was broken.

The best solution here is to remove this functionality, since
it was basically unused in the repository. Only some integration
tests inside urlgetter bothered with these metrics.

A more clinical fix would have been to use ooni/oohttp/httptrace
instead of net/http/httptrace in the stdlib, but it does not
seem to be a good idea, given that those metrics were not used.

With this diff applied, we'll further reduce the number of locally
failing integration tests to just jafar-specific tests.

This diff WILL need to be forwardported to `master`.
2022-02-09 15:08:19 +01:00
..
experiment [forwardport] fix(netx): stop collecting HTTP performance metrics (#689) 2022-02-09 15:08:19 +01:00
geolocate fix(geolocate): enforce 7s timeout for each lookupper (#678) 2022-02-09 13:22:01 +01:00
httpheader feat: start preparing for a cli release (#672) 2022-01-24 14:56:51 +01:00
internal fix(resolvermake): re-enable dns.google DoH HTTP3 resolutions (#680) 2022-01-31 19:12:43 +01:00
legacy cleanup: merge legacy errorsx in netxlite and hide classifiers (#655) 2022-01-07 17:31:21 +01:00
mockable feat(torsf): collect tor logs, select rendezvous method, count bytes (#683) 2022-02-07 17:05:36 +01:00
netx [forwardport] fix(netx): stop collecting HTTP performance metrics (#689) 2022-02-09 15:08:19 +01:00
probeservices refactor: move httpx into the internal package (#646) 2022-01-05 17:17:20 +01:00
testdata fix: add missing files causing tests to fail (#202) 2021-02-02 14:18:22 +01:00
.gitignore feat: support embedding encrypted psiphon config (#285) 2021-04-02 17:36:06 +02:00
allexperiments.go refactor: introduce and use InputOrStaticDefault (#632) 2021-12-03 15:30:56 +01:00
doc.go feat(engine): allow runner to return many measurements (#527) 2021-09-30 00:54:52 +02:00
experiment_integration_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
experiment_internal_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
experiment_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
experiment.go feat(torsf): collect tor logs, select rendezvous method, count bytes (#683) 2022-02-07 17:05:36 +01:00
experimentbuilder_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
experimentbuilder.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
inputloader_network_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
inputloader_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
inputloader.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
inputprocessor_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
inputprocessor.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
saver_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
saver.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
session_integration_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
session_internal_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
session_nopsiphon_test.go [forwardport] fix(mk): do nothing if we already have psiphon config (#605) (#606) 2021-11-19 12:40:10 +01:00
session_nopsiphon.go [forwardport] fix(mk): do nothing if we already have psiphon config (#605) (#606) 2021-11-19 12:40:10 +01:00
session_psiphon_test.go [forwardport] fix(mk): do nothing if we already have psiphon config (#605) (#606) 2021-11-19 12:40:10 +01:00
session_psiphon.go [forwardport] fix(mk): do nothing if we already have psiphon config (#605) (#606) 2021-11-19 12:40:10 +01:00
session.go feat(torsf): collect tor logs, select rendezvous method, count bytes (#683) 2022-02-07 17:05:36 +01:00
submitter_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
submitter.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00