7df25795c0
See https://github.com/ooni/probe/issues/2147. Note that this PR also tries to reduce usage of legacy names inside unit/integration tests.
594 lines
15 KiB
Go
594 lines
15 KiB
Go
package probeservices_test
|
||
|
||
import (
|
||
"context"
|
||
"errors"
|
||
"io"
|
||
"net/http"
|
||
"strings"
|
||
"testing"
|
||
"time"
|
||
|
||
"github.com/apex/log"
|
||
"github.com/google/go-cmp/cmp"
|
||
"github.com/ooni/probe-cli/v3/internal/engine/mockable"
|
||
"github.com/ooni/probe-cli/v3/internal/engine/probeservices"
|
||
"github.com/ooni/probe-cli/v3/internal/engine/probeservices/testorchestra"
|
||
"github.com/ooni/probe-cli/v3/internal/model"
|
||
"github.com/ooni/probe-cli/v3/internal/netxlite"
|
||
)
|
||
|
||
func newclient() *probeservices.Client {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{
|
||
MockableHTTPClient: http.DefaultClient,
|
||
MockableLogger: log.Log,
|
||
},
|
||
model.OOAPIService{
|
||
Address: "https://ams-pg-test.ooni.org/",
|
||
Type: "https",
|
||
},
|
||
)
|
||
if err != nil {
|
||
panic(err) // so fail the test
|
||
}
|
||
return client
|
||
}
|
||
|
||
func TestNewClientHTTPS(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "https://x.org",
|
||
Type: "https",
|
||
})
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
if client.BaseURL != "https://x.org" {
|
||
t.Fatal("not the URL we expected")
|
||
}
|
||
}
|
||
|
||
func TestNewClientUnsupportedEndpoint(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "https://x.org",
|
||
Type: "onion",
|
||
})
|
||
if !errors.Is(err, probeservices.ErrUnsupportedEndpoint) {
|
||
t.Fatal("not the error we expected")
|
||
}
|
||
if client != nil {
|
||
t.Fatal("expected nil client here")
|
||
}
|
||
}
|
||
|
||
func TestNewClientCloudfrontInvalidURL(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "\t\t\t",
|
||
Type: "cloudfront",
|
||
})
|
||
if err == nil || !strings.HasSuffix(err.Error(), "invalid control character in URL") {
|
||
t.Fatal("not the error we expected")
|
||
}
|
||
if client != nil {
|
||
t.Fatal("expected nil client here")
|
||
}
|
||
}
|
||
|
||
func TestNewClientCloudfrontInvalidURLScheme(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "http://x.org",
|
||
Type: "cloudfront",
|
||
})
|
||
if !errors.Is(err, probeservices.ErrUnsupportedCloudFrontAddress) {
|
||
t.Fatal("not the error we expected")
|
||
}
|
||
if client != nil {
|
||
t.Fatal("expected nil client here")
|
||
}
|
||
}
|
||
|
||
func TestNewClientCloudfrontInvalidURLWithPort(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "https://x.org:54321",
|
||
Type: "cloudfront",
|
||
})
|
||
if !errors.Is(err, probeservices.ErrUnsupportedCloudFrontAddress) {
|
||
t.Fatal("not the error we expected")
|
||
}
|
||
if client != nil {
|
||
t.Fatal("expected nil client here")
|
||
}
|
||
}
|
||
|
||
func TestNewClientCloudfrontInvalidFront(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "https://x.org",
|
||
Type: "cloudfront",
|
||
Front: "\t\t\t",
|
||
})
|
||
if err == nil || !strings.HasSuffix(err.Error(), `invalid URL escape "%09"`) {
|
||
t.Fatal("not the error we expected")
|
||
}
|
||
if client != nil {
|
||
t.Fatal("expected nil client here")
|
||
}
|
||
}
|
||
|
||
func TestNewClientCloudfrontGood(t *testing.T) {
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "https://x.org",
|
||
Type: "cloudfront",
|
||
Front: "google.com",
|
||
})
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
if client.BaseURL != "https://google.com" {
|
||
t.Fatal("not the BaseURL we expected")
|
||
}
|
||
if client.Host != "x.org" {
|
||
t.Fatal("not the Host we expected")
|
||
}
|
||
}
|
||
|
||
func TestCloudfront(t *testing.T) {
|
||
if testing.Short() {
|
||
t.Skip("skip test in short mode")
|
||
}
|
||
client, err := probeservices.NewClient(
|
||
&mockable.Session{}, model.OOAPIService{
|
||
Address: "https://meek.azureedge.net",
|
||
Type: "cloudfront",
|
||
Front: "ajax.aspnetcdn.com",
|
||
})
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
req, err := http.NewRequest("GET", client.BaseURL, nil)
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
req.Host = client.Host
|
||
resp, err := http.DefaultTransport.RoundTrip(req)
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
defer resp.Body.Close()
|
||
if resp.StatusCode != 200 {
|
||
t.Fatal("unexpected status code")
|
||
}
|
||
data, err := netxlite.ReadAllContext(req.Context(), resp.Body)
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
if string(data) != "I’m just a happy little web server.\n" {
|
||
t.Fatal("unexpected response body")
|
||
}
|
||
}
|
||
|
||
func TestDefaultProbeServicesWorkAsIntended(t *testing.T) {
|
||
if testing.Short() {
|
||
t.Skip("skip test in short mode")
|
||
}
|
||
for _, e := range probeservices.Default() {
|
||
client, err := probeservices.NewClient(&mockable.Session{
|
||
MockableHTTPClient: http.DefaultClient,
|
||
MockableLogger: log.Log,
|
||
}, e)
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
testhelpers, err := client.GetTestHelpers(context.Background())
|
||
if err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
if len(testhelpers) < 1 {
|
||
t.Fatal("no test helpers?!")
|
||
}
|
||
}
|
||
}
|
||
|
||
func TestSortEndpoints(t *testing.T) {
|
||
in := []model.OOAPIService{{
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://ams-ps2.ooni.nu:443",
|
||
}}
|
||
expect := []model.OOAPIService{{
|
||
Type: "https",
|
||
Address: "https://ams-ps2.ooni.nu:443",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}}
|
||
out := probeservices.SortEndpoints(in)
|
||
diff := cmp.Diff(out, expect)
|
||
if diff != "" {
|
||
t.Fatal(diff)
|
||
}
|
||
}
|
||
|
||
func TestOnlyHTTPS(t *testing.T) {
|
||
in := []model.OOAPIService{{
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://ams-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://hkg-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://mia-ps-nonexistent.ooni.io",
|
||
}}
|
||
expect := []model.OOAPIService{{
|
||
Type: "https",
|
||
Address: "https://ams-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://hkg-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://mia-ps-nonexistent.ooni.io",
|
||
}}
|
||
out := probeservices.OnlyHTTPS(in)
|
||
diff := cmp.Diff(out, expect)
|
||
if diff != "" {
|
||
t.Fatal(diff)
|
||
}
|
||
}
|
||
|
||
func TestOnlyFallbacks(t *testing.T) {
|
||
// put onion first so we also verify that we sort the endpoints
|
||
in := []model.OOAPIService{{
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://ams-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://hkg-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://mia-ps-nonexistent.ooni.io",
|
||
}}
|
||
expect := []model.OOAPIService{{
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}}
|
||
out := probeservices.OnlyFallbacks(in)
|
||
diff := cmp.Diff(out, expect)
|
||
if diff != "" {
|
||
t.Fatal(diff)
|
||
}
|
||
}
|
||
|
||
func TestTryAllCanceledContext(t *testing.T) {
|
||
// put onion first so we also verify that we sort the endpoints
|
||
in := []model.OOAPIService{{
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://ams-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://hkg-ps-nonexistent.ooni.io",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://mia-ps-nonexistent.ooni.io",
|
||
}}
|
||
ctx, cancel := context.WithCancel(context.Background())
|
||
cancel() // immediately cancel and cause every attempt to fail
|
||
sess := &mockable.Session{
|
||
MockableHTTPClient: http.DefaultClient,
|
||
MockableLogger: log.Log,
|
||
}
|
||
out := probeservices.TryAll(ctx, sess, in)
|
||
if len(out) != 5 {
|
||
t.Fatal("invalid number of entries")
|
||
}
|
||
//
|
||
if out[0].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !errors.Is(out[0].Err, context.Canceled) {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[0].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[0].Endpoint.Address != "https://ams-ps-nonexistent.ooni.io" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
if out[1].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !errors.Is(out[1].Err, context.Canceled) {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[1].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[1].Endpoint.Address != "https://hkg-ps-nonexistent.ooni.io" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
if out[2].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !errors.Is(out[2].Err, context.Canceled) {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[2].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[2].Endpoint.Address != "https://mia-ps-nonexistent.ooni.io" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
if out[3].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !errors.Is(out[3].Err, context.Canceled) {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[3].Endpoint.Type != "cloudfront" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[3].Endpoint.Front != "dkyhjv0wpi2dk.cloudfront.net" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[3].Endpoint.Address != "https://dkyhjv0wpi2dk.cloudfront.net" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
// Note: here duration may be zero because the endpoint is not supported
|
||
// and so we don't basically do anything. But it also may be nonzero since
|
||
// we also run tests in the cloud, which is slower than my desktop. So, I
|
||
// have not written a specific test concerning out[4].Duration.
|
||
if !errors.Is(out[4].Err, probeservices.ErrUnsupportedEndpoint) {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[4].Endpoint.Type != "onion" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[4].Endpoint.Address != "httpo://jehhrikjjqrlpufu.onion" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
}
|
||
|
||
func TestTryAllIntegrationWeRaceForFastestHTTPS(t *testing.T) {
|
||
if testing.Short() {
|
||
t.Skip("skip test in short mode")
|
||
}
|
||
// put onion first so we also verify that we sort the endpoints
|
||
in := []model.OOAPIService{{
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://api.ooni.io",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}}
|
||
sess := &mockable.Session{
|
||
MockableHTTPClient: http.DefaultClient,
|
||
MockableLogger: log.Log,
|
||
}
|
||
out := probeservices.TryAll(context.Background(), sess, in)
|
||
if len(out) != 1 {
|
||
t.Fatal("invalid number of entries")
|
||
}
|
||
//
|
||
if out[0].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if out[0].Err != nil {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[0].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[0].Endpoint.Address != "https://api.ooni.io" {
|
||
t.Fatal("invalid endpoint address")
|
||
}
|
||
}
|
||
|
||
func TestTryAllIntegrationWeFallback(t *testing.T) {
|
||
if testing.Short() {
|
||
t.Skip("skip test in short mode")
|
||
}
|
||
// put onion first so we also verify that we sort the endpoints
|
||
in := []model.OOAPIService{{
|
||
Type: "onion",
|
||
Address: "httpo://jehhrikjjqrlpufu.onion",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://ps-nonexistent.ooni.io",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://hkg-ps-nonexistent.ooni.nu",
|
||
}, {
|
||
Front: "dkyhjv0wpi2dk.cloudfront.net",
|
||
Type: "cloudfront",
|
||
Address: "https://dkyhjv0wpi2dk.cloudfront.net",
|
||
}, {
|
||
Type: "https",
|
||
Address: "https://mia-ps2-nonexistent.ooni.nu",
|
||
}}
|
||
sess := &mockable.Session{
|
||
MockableHTTPClient: http.DefaultClient,
|
||
MockableLogger: log.Log,
|
||
}
|
||
out := probeservices.TryAll(context.Background(), sess, in)
|
||
if len(out) != 4 {
|
||
t.Fatal("invalid number of entries")
|
||
}
|
||
//
|
||
if out[0].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !strings.HasSuffix(out[0].Err.Error(), "no such host") {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[0].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[0].Endpoint.Address != "https://ps-nonexistent.ooni.io" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
if out[1].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !strings.HasSuffix(out[1].Err.Error(), "no such host") {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[1].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[1].Endpoint.Address != "https://hkg-ps-nonexistent.ooni.nu" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
if out[2].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if !strings.HasSuffix(out[2].Err.Error(), "no such host") {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[2].Endpoint.Type != "https" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[2].Endpoint.Address != "https://mia-ps2-nonexistent.ooni.nu" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
//
|
||
if out[3].Duration <= 0 {
|
||
t.Fatal("invalid duration")
|
||
}
|
||
if out[3].Err != nil {
|
||
t.Fatal("invalid error")
|
||
}
|
||
if out[3].Endpoint.Type != "cloudfront" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[3].Endpoint.Address != "https://dkyhjv0wpi2dk.cloudfront.net" {
|
||
t.Fatal("invalid endpoint type")
|
||
}
|
||
if out[3].Endpoint.Front != "dkyhjv0wpi2dk.cloudfront.net" {
|
||
t.Fatal("invalid front")
|
||
}
|
||
}
|
||
|
||
func TestSelectBestEmptyInput(t *testing.T) {
|
||
if out := probeservices.SelectBest(nil); out != nil {
|
||
t.Fatal("expected nil output here")
|
||
}
|
||
}
|
||
|
||
func TestSelectBestOnlyFailures(t *testing.T) {
|
||
in := []*probeservices.Candidate{{
|
||
Duration: 10 * time.Millisecond,
|
||
Err: io.EOF,
|
||
}}
|
||
if out := probeservices.SelectBest(in); out != nil {
|
||
t.Fatal("expected nil output here")
|
||
}
|
||
}
|
||
|
||
func TestSelectBestSelectsTheFastest(t *testing.T) {
|
||
in := []*probeservices.Candidate{{
|
||
Duration: 10 * time.Millisecond,
|
||
Endpoint: model.OOAPIService{
|
||
Address: "https://ps1.ooni.nonexistent",
|
||
Type: "https",
|
||
},
|
||
}, {
|
||
Duration: 4 * time.Millisecond,
|
||
Endpoint: model.OOAPIService{
|
||
Address: "https://ps2.ooni.nonexistent",
|
||
Type: "https",
|
||
},
|
||
}, {
|
||
Duration: 7 * time.Millisecond,
|
||
Endpoint: model.OOAPIService{
|
||
Address: "https://ps3.ooni.nonexistent",
|
||
Type: "https",
|
||
},
|
||
}, {
|
||
Duration: 11 * time.Millisecond,
|
||
Endpoint: model.OOAPIService{
|
||
Address: "https://ps4.ooni.nonexistent",
|
||
Type: "https",
|
||
},
|
||
}}
|
||
expected := &probeservices.Candidate{
|
||
Duration: 4 * time.Millisecond,
|
||
Endpoint: model.OOAPIService{
|
||
Address: "https://ps2.ooni.nonexistent",
|
||
Type: "https",
|
||
},
|
||
}
|
||
out := probeservices.SelectBest(in)
|
||
if diff := cmp.Diff(out, expected); diff != "" {
|
||
t.Fatal(diff)
|
||
}
|
||
}
|
||
|
||
func TestGetCredsAndAuthNotLoggedIn(t *testing.T) {
|
||
clnt := newclient()
|
||
if err := clnt.MaybeRegister(context.Background(), testorchestra.MetadataFixture()); err != nil {
|
||
t.Fatal(err)
|
||
}
|
||
creds, auth, err := clnt.GetCredsAndAuth()
|
||
if !errors.Is(err, probeservices.ErrNotLoggedIn) {
|
||
t.Fatal("not the error we expected")
|
||
}
|
||
if creds != nil {
|
||
t.Fatal("expected nil creds here")
|
||
}
|
||
if auth != nil {
|
||
t.Fatal("expected nil auth here")
|
||
}
|
||
}
|