This diff changes the software name used by unattended runs for which we did not override the default software name (`ooniprobe-cli`). It will become `ooniprobe-cli-unattended`. This software name is in line with the one we use for Android, iOS, and desktop unattended runs. While working in this diff, I introduced string constants for the run types and a string constant for the default software name. See https://github.com/ooni/probe/issues/2081.
		
			
				
	
	
		
			73 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			73 lines
		
	
	
		
			1.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package probeservices_test
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 	"strings"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/ooni/probe-cli/v3/internal/model"
 | |
| )
 | |
| 
 | |
| func TestCheckInSuccess(t *testing.T) {
 | |
| 	client := newclient()
 | |
| 	client.BaseURL = "https://ams-pg-test.ooni.org"
 | |
| 	config := model.OOAPICheckInConfig{
 | |
| 		Charging:        true,
 | |
| 		OnWiFi:          true,
 | |
| 		Platform:        "android",
 | |
| 		ProbeASN:        "AS12353",
 | |
| 		ProbeCC:         "PT",
 | |
| 		RunType:         model.RunTypeTimed,
 | |
| 		SoftwareName:    "ooniprobe-android",
 | |
| 		SoftwareVersion: "2.7.1",
 | |
| 		WebConnectivity: model.OOAPICheckInConfigWebConnectivity{
 | |
| 			CategoryCodes: []string{"NEWS", "CULTR"},
 | |
| 		},
 | |
| 	}
 | |
| 	ctx := context.Background()
 | |
| 	result, err := client.CheckIn(ctx, config)
 | |
| 	if err != nil {
 | |
| 		t.Fatal(err)
 | |
| 	}
 | |
| 	if result == nil || result.WebConnectivity == nil {
 | |
| 		t.Fatal("got nil result or WebConnectivity")
 | |
| 	}
 | |
| 	if result.WebConnectivity.ReportID == "" {
 | |
| 		t.Fatal("ReportID is empty")
 | |
| 	}
 | |
| 	if len(result.WebConnectivity.URLs) < 1 {
 | |
| 		t.Fatal("unexpected number of URLs")
 | |
| 	}
 | |
| 	for _, entry := range result.WebConnectivity.URLs {
 | |
| 		if entry.CategoryCode != "NEWS" && entry.CategoryCode != "CULTR" {
 | |
| 			t.Fatalf("unexpected category code: %+v", entry)
 | |
| 		}
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestCheckInFailure(t *testing.T) {
 | |
| 	client := newclient()
 | |
| 	client.BaseURL = "https://\t\t\t/" // cause test to fail
 | |
| 	config := model.OOAPICheckInConfig{
 | |
| 		Charging:        true,
 | |
| 		OnWiFi:          true,
 | |
| 		Platform:        "android",
 | |
| 		ProbeASN:        "AS12353",
 | |
| 		ProbeCC:         "PT",
 | |
| 		RunType:         model.RunTypeTimed,
 | |
| 		SoftwareName:    "ooniprobe-android",
 | |
| 		SoftwareVersion: "2.7.1",
 | |
| 		WebConnectivity: model.OOAPICheckInConfigWebConnectivity{
 | |
| 			CategoryCodes: []string{"NEWS", "CULTR"},
 | |
| 		},
 | |
| 	}
 | |
| 	ctx := context.Background()
 | |
| 	result, err := client.CheckIn(ctx, config)
 | |
| 	if err == nil || !strings.HasSuffix(err.Error(), "invalid control character in URL") {
 | |
| 		t.Fatal("not the error we expected")
 | |
| 	}
 | |
| 	if result != nil {
 | |
| 		t.Fatal("results?!")
 | |
| 	}
 | |
| }
 |