acef18a955
The BogonResolver relied on its wrapper resolver to pass along the list of addresses _and_ the error. But the idiomatic thing to do is often to return `nil` when there is an error. I broke this very fragile assumption in https://github.com/ooni/probe-cli/pull/399. I could of course fix it, but this assumption is clearly wrong and we should not allow such fragile code in the tree. We are not using BogonIsError much in the tree. The only place in which we're using it for measuring seems to be dnscheck. It may be that this surprising behavior was what caused the issue at https://github.com/ooni/probe/issues/1510 in the first place. Regardless, let's remove fragile code and adjust the test that was failing. Also that test is quick so it can run in `-short` mode. Spotted while working on https://github.com/ooni/probe/issues/1505. |
||
|---|---|---|
| .. | ||
| atomicx | ||
| bytecounter | ||
| cmd | ||
| engine | ||
| fsx | ||
| humanize | ||
| iox | ||
| kvstore | ||
| mlablocate | ||
| mlablocatev2 | ||
| multierror | ||
| netxlite | ||
| netxmocks | ||
| ooapi | ||
| platform | ||
| ptx | ||
| randx | ||
| runtimex | ||
| scrubber | ||
| shellx | ||
| tunnel | ||
| tutorial | ||
| version | ||
| README.md | ||
Directory github.com/ooni/probe-cli/internal
This directory contains private Go packages.