## Checklist - [x] I have read the [contribution guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md) - [x] reference issue for this pull request: https://github.com/ooni/probe/issues/1885 - [x] related ooni/spec pull request: N/A Location of the issue tracker: https://github.com/ooni/probe ## Description This PR contains a set of changes to move important interfaces and data types into the `./internal/model` package. The criteria for including an interface or data type in here is roughly that the type should be important and used by several packages. We are especially interested to move more interfaces here to increase modularity. An additional side effect is that, by reading this package, one should be able to understand more quickly how different parts of the codebase interact with each other. This is what I want to move in `internal/model`: - [x] most important interfaces from `internal/netxlite` - [x] everything that was previously part of `internal/engine/model` - [x] mocks from `internal/netxlite/mocks` should also be moved in here as a subpackage
		
			
				
	
	
		
			42 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			42 lines
		
	
	
		
			1.1 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package mocks
 | |
| 
 | |
| import (
 | |
| 	"context"
 | |
| 
 | |
| 	"github.com/ooni/probe-cli/v3/internal/model"
 | |
| )
 | |
| 
 | |
| // Resolver is a mockable Resolver.
 | |
| type Resolver struct {
 | |
| 	MockLookupHost           func(ctx context.Context, domain string) ([]string, error)
 | |
| 	MockNetwork              func() string
 | |
| 	MockAddress              func() string
 | |
| 	MockCloseIdleConnections func()
 | |
| 	MockLookupHTTPS          func(ctx context.Context, domain string) (*model.HTTPSSvc, error)
 | |
| }
 | |
| 
 | |
| // LookupHost calls MockLookupHost.
 | |
| func (r *Resolver) LookupHost(ctx context.Context, domain string) ([]string, error) {
 | |
| 	return r.MockLookupHost(ctx, domain)
 | |
| }
 | |
| 
 | |
| // Address calls MockAddress.
 | |
| func (r *Resolver) Address() string {
 | |
| 	return r.MockAddress()
 | |
| }
 | |
| 
 | |
| // Network calls MockNetwork.
 | |
| func (r *Resolver) Network() string {
 | |
| 	return r.MockNetwork()
 | |
| }
 | |
| 
 | |
| // CloseIdleConnections calls MockCloseIdleConnections.
 | |
| func (r *Resolver) CloseIdleConnections() {
 | |
| 	r.MockCloseIdleConnections()
 | |
| }
 | |
| 
 | |
| // LookupHTTPS calls MockLookupHTTPS.
 | |
| func (r *Resolver) LookupHTTPS(ctx context.Context, domain string) (*model.HTTPSSvc, error) {
 | |
| 	return r.MockLookupHTTPS(ctx, domain)
 | |
| }
 |