History

Simone Basso 1c057d322d cleanup: merge legacy errorsx in netxlite and hide classifiers (#655 ) This diff implements the first two cleanups defined at https://github.com/ooni/probe/issues/1956: > - [ ] observe that `netxlite` and `netx` differ in error wrapping only in the way in which we set `ErrWrapper.Operation`. Observe that the code using `netxlite` does not care about such a field. Therefore, we can modify `netxlite` to set such a field using the code of `netx` and we can remove `netx` specific code for errors (which currently lives inside of the `./internal/engine/legacy/errorsx` package > > - [ ] after we've done the previous cleanup, we can make all the classifiers code private, since there's no code outside `netxlite` that needs them A subsequent diff will address the remaining cleanup. While there, notice that there are failing, unrelated obfs4 tests, so disable them in short mode. (I am confident these tests are unrelated because they fail for me when running test locally from the `master` branch.)	2022-01-07 17:31:21 +01:00
..
assetsdir	refactor: redesign how we import assets (#260 )	2021-04-01 16:57:31 +02:00
README.md	chore: merge probe-engine into probe-cli (#201 )	2021-02-02 12:05:47 +01:00

cleanup: merge legacy errorsx in netxlite and hide classifiers (#655 )

This diff implements the first two cleanups defined at https://github.com/ooni/probe/issues/1956:

> - [ ] observe that `netxlite` and `netx` differ in error wrapping only in the way in which we set `ErrWrapper.Operation`. Observe that the code using `netxlite` does not care about such a field. Therefore, we can modify `netxlite` to set such a field using the code of `netx` and we can remove `netx` specific code for errors (which currently lives inside of the `./internal/engine/legacy/errorsx` package
>
> - [ ] after we've done the previous cleanup, we can make all the classifiers code private, since there's no code outside `netxlite` that needs them

A subsequent diff will address the remaining cleanup.

While there, notice that there are failing, unrelated obfs4 tests, so disable them in short mode. (I am confident these tests are unrelated because they fail for me when running test locally from the `master` branch.)

2022-01-07 17:31:21 +01:00

assetsdir

refactor: redesign how we import assets (#260 )

2021-04-01 16:57:31 +02:00

README.md

chore: merge probe-engine into probe-cli (#201 )

2021-02-02 12:05:47 +01:00

README.md

Package github.com/ooni/probe-engine/legacy

This package contains legacy code that we will soon remove. When this folder is empty, it means there's no large, incremental refactoring in progress.