034db78f94
* feat(sessionresolver): try many and use what works * fix(sessionresolver): make sure we can use quic * fix: the config struct is unnecessary * fix: make kvstore optional * feat: write simple integration test * feat: start adding tests * feat: continue writing tests * fix(sessionresolver): add more unit tests * fix(sessionresolver): finish adding tests * refactor(sessionresolver): changes after code review
53 lines
1.2 KiB
Go
53 lines
1.2 KiB
Go
package sessionresolver
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/ooni/probe-cli/v3/internal/engine/netx"
|
|
)
|
|
|
|
type fakeDNSClientMaker struct {
|
|
reso childResolver
|
|
err error
|
|
savedConfig netx.Config
|
|
savedURL string
|
|
}
|
|
|
|
func (c *fakeDNSClientMaker) Make(config netx.Config, URL string) (childResolver, error) {
|
|
c.savedConfig = config
|
|
c.savedURL = URL
|
|
return c.reso, c.err
|
|
}
|
|
|
|
func TestClientMakerWithOverride(t *testing.T) {
|
|
m := &fakeDNSClientMaker{err: io.EOF}
|
|
reso := &Resolver{dnsClientMaker: m}
|
|
out, err := reso.clientmaker().Make(netx.Config{}, "https://dns.google/dns-query")
|
|
if !errors.Is(err, io.EOF) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if out != nil {
|
|
t.Fatal("expected nil here")
|
|
}
|
|
}
|
|
|
|
func TestClientDefaultWithCancelledContext(t *testing.T) {
|
|
reso := &Resolver{}
|
|
re, err := reso.clientmaker().Make(netx.Config{}, "https://dns.google/dns-query")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel() // fail immediately
|
|
out, err := re.LookupHost(ctx, "dns.google")
|
|
if !errors.Is(err, context.Canceled) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if out != nil {
|
|
t.Fatal("expected nil output")
|
|
}
|
|
}
|