bbcd2e2280
This diff creates a new package under netx called tracex that contains everything we need to perform measurements using events tracing and postprocessing (which is the technique with which we implement most network experiments). The general idea here is to (1) create a unique package out of all of these packages; (2) clean up the code a bit (improve tests, docs, apply more recent code patterns); (3) move the resulting code as a toplevel package inside of internal. Once this is done, netx can be further refactored to avoid subpackages and we can search for more code to salvage/refactor. See https://github.com/ooni/probe/issues/2121
331 lines
7.2 KiB
Go
331 lines
7.2 KiB
Go
package dash
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"io"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/apex/log"
|
|
"github.com/montanaflynn/stats"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/mockable"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/netx/tracex"
|
|
"github.com/ooni/probe-cli/v3/internal/model"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite"
|
|
)
|
|
|
|
func TestRunnerLoopLocateFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
r := runner{
|
|
callbacks: model.NewPrinterCallbacks(log.Log),
|
|
httpClient: &http.Client{
|
|
Transport: FakeHTTPTransport{
|
|
err: expected,
|
|
},
|
|
},
|
|
saver: new(tracex.Saver),
|
|
sess: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
tk: new(TestKeys),
|
|
}
|
|
err := r.loop(context.Background(), 1)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestRunnerLoopNegotiateFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
r := runner{
|
|
callbacks: model.NewPrinterCallbacks(log.Log),
|
|
httpClient: &http.Client{
|
|
Transport: &FakeHTTPTransportStack{
|
|
all: []FakeHTTPTransport{
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"fqdn": "ams01.measurementlab.net"}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{err: expected},
|
|
},
|
|
},
|
|
},
|
|
saver: new(tracex.Saver),
|
|
sess: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
tk: new(TestKeys),
|
|
}
|
|
err := r.loop(context.Background(), 1)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestRunnerLoopMeasureFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
r := runner{
|
|
callbacks: model.NewPrinterCallbacks(log.Log),
|
|
httpClient: &http.Client{
|
|
Transport: &FakeHTTPTransportStack{
|
|
all: []FakeHTTPTransport{
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"fqdn": "ams01.measurementlab.net"}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"authorization": "xx", "unchoked": 1}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{err: expected},
|
|
},
|
|
},
|
|
},
|
|
saver: new(tracex.Saver),
|
|
sess: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
tk: new(TestKeys),
|
|
}
|
|
err := r.loop(context.Background(), 1)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestRunnerLoopCollectFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
saver := new(tracex.Saver)
|
|
saver.Write(tracex.Event{Name: netxlite.ConnectOperation, Duration: 150 * time.Millisecond})
|
|
r := runner{
|
|
callbacks: model.NewPrinterCallbacks(log.Log),
|
|
httpClient: &http.Client{
|
|
Transport: &FakeHTTPTransportStack{
|
|
all: []FakeHTTPTransport{
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"fqdn": "ams01.measurementlab.net"}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"authorization": "xx", "unchoked": 1}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(`1234567`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{err: expected},
|
|
},
|
|
},
|
|
},
|
|
saver: saver,
|
|
sess: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
tk: new(TestKeys),
|
|
}
|
|
err := r.loop(context.Background(), 1)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestRunnerLoopSuccess(t *testing.T) {
|
|
saver := new(tracex.Saver)
|
|
saver.Write(tracex.Event{Name: netxlite.ConnectOperation, Duration: 150 * time.Millisecond})
|
|
r := runner{
|
|
callbacks: model.NewPrinterCallbacks(log.Log),
|
|
httpClient: &http.Client{
|
|
Transport: &FakeHTTPTransportStack{
|
|
all: []FakeHTTPTransport{
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"fqdn": "ams01.measurementlab.net"}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(
|
|
`{"authorization": "xx", "unchoked": 1}`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(`1234567`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
{
|
|
resp: &http.Response{
|
|
Body: io.NopCloser(strings.NewReader(`[]`)),
|
|
StatusCode: 200,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
saver: saver,
|
|
sess: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
tk: new(TestKeys),
|
|
}
|
|
err := r.loop(context.Background(), 1)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestTestKeysAnalyzeWithNoData(t *testing.T) {
|
|
tk := &TestKeys{}
|
|
err := tk.analyze()
|
|
if !errors.Is(err, stats.EmptyInputErr) {
|
|
t.Fatal("expected an error here")
|
|
}
|
|
}
|
|
|
|
func TestTestKeysAnalyzeMedian(t *testing.T) {
|
|
tk := &TestKeys{
|
|
ReceiverData: []clientResults{
|
|
{
|
|
Rate: 1,
|
|
},
|
|
{
|
|
Rate: 2,
|
|
},
|
|
{
|
|
Rate: 3,
|
|
},
|
|
},
|
|
}
|
|
err := tk.analyze()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if tk.Simple.MedianBitrate != 2 {
|
|
t.Fatal("unexpected median value")
|
|
}
|
|
}
|
|
|
|
func TestTestKeysAnalyzeMinPlayoutDelay(t *testing.T) {
|
|
tk := &TestKeys{
|
|
ReceiverData: []clientResults{
|
|
{
|
|
ElapsedTarget: 2,
|
|
Elapsed: 1.4,
|
|
},
|
|
{
|
|
ElapsedTarget: 2,
|
|
Elapsed: 3.0,
|
|
},
|
|
{
|
|
ElapsedTarget: 2,
|
|
Elapsed: 1.8,
|
|
},
|
|
},
|
|
}
|
|
err := tk.analyze()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if tk.Simple.MinPlayoutDelay < 0.99 || tk.Simple.MinPlayoutDelay > 1.01 {
|
|
t.Fatal("unexpected min-playout-delay value")
|
|
}
|
|
}
|
|
|
|
func TestNewExperimentMeasurer(t *testing.T) {
|
|
measurer := NewExperimentMeasurer(Config{})
|
|
if measurer.ExperimentName() != "dash" {
|
|
t.Fatal("unexpected name")
|
|
}
|
|
if measurer.ExperimentVersion() != "0.13.0" {
|
|
t.Fatal("unexpected version")
|
|
}
|
|
}
|
|
|
|
func TestMeasureWithCancelledContext(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel() // cause failure
|
|
measurement := new(model.Measurement)
|
|
m := &Measurer{}
|
|
err := m.Run(
|
|
ctx,
|
|
&mockable.Session{
|
|
MockableHTTPClient: http.DefaultClient,
|
|
MockableLogger: log.Log,
|
|
},
|
|
measurement,
|
|
model.NewPrinterCallbacks(log.Log),
|
|
)
|
|
// See corresponding comment in Measurer.Run implementation to
|
|
// understand why here it's correct to return nil.
|
|
if !errors.Is(err, nil) {
|
|
t.Fatal("unexpected error value")
|
|
}
|
|
sk, err := m.GetSummaryKeys(measurement)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, ok := sk.(SummaryKeys); !ok {
|
|
t.Fatal("invalid type for summary keys")
|
|
}
|
|
}
|
|
|
|
func TestSummaryKeysInvalidType(t *testing.T) {
|
|
measurement := new(model.Measurement)
|
|
m := &Measurer{}
|
|
_, err := m.GetSummaryKeys(measurement)
|
|
if err.Error() != "invalid test keys type" {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestSummaryKeysGood(t *testing.T) {
|
|
measurement := &model.Measurement{TestKeys: &TestKeys{Simple: Simple{
|
|
ConnectLatency: 1234,
|
|
MedianBitrate: 123,
|
|
MinPlayoutDelay: 12,
|
|
}}}
|
|
m := &Measurer{}
|
|
osk, err := m.GetSummaryKeys(measurement)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
sk := osk.(SummaryKeys)
|
|
if sk.Latency != 1234 {
|
|
t.Fatal("invalid latency")
|
|
}
|
|
if sk.Bitrate != 123 {
|
|
t.Fatal("invalid bitrate")
|
|
}
|
|
if sk.Delay != 12 {
|
|
t.Fatal("invalid delay")
|
|
}
|
|
if sk.IsAnomaly {
|
|
t.Fatal("invalid isAnomaly")
|
|
}
|
|
}
|