aa77867145
This quirk really saddens me. It's a piece of tech debt we're carrying over from the original netx implementation. We cannot remove it _until_ we have legacy netx code around. The second best thing we can do is to clearly move this code in a place where it's clear it's a quirk and write and use some extra code that makes sure the quirk's assumptions are always met. Sigh. See https://github.com/ooni/probe/issues/1591
73 lines
1.7 KiB
Go
73 lines
1.7 KiB
Go
package netxlite
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/ooni/probe-cli/v3/internal/errorsx"
|
|
)
|
|
|
|
func TestQuirkReduceErrors(t *testing.T) {
|
|
t.Run("no errors", func(t *testing.T) {
|
|
result := quirkReduceErrors(nil)
|
|
if result != nil {
|
|
t.Fatal("wrong result")
|
|
}
|
|
})
|
|
t.Run("single error", func(t *testing.T) {
|
|
err := errors.New("mocked error")
|
|
result := quirkReduceErrors([]error{err})
|
|
if result != err {
|
|
t.Fatal("wrong result")
|
|
}
|
|
})
|
|
t.Run("multiple errors", func(t *testing.T) {
|
|
err1 := errors.New("mocked error #1")
|
|
err2 := errors.New("mocked error #2")
|
|
result := quirkReduceErrors([]error{err1, err2})
|
|
if result.Error() != "mocked error #1" {
|
|
t.Fatal("wrong result")
|
|
}
|
|
})
|
|
t.Run("multiple errors with meaningful ones", func(t *testing.T) {
|
|
err1 := errors.New("mocked error #1")
|
|
err2 := &errorsx.ErrWrapper{
|
|
Failure: "unknown_failure: antani",
|
|
}
|
|
err3 := &errorsx.ErrWrapper{
|
|
Failure: errorsx.FailureConnectionRefused,
|
|
}
|
|
err4 := errors.New("mocked error #3")
|
|
result := quirkReduceErrors([]error{err1, err2, err3, err4})
|
|
if result.Error() != errorsx.FailureConnectionRefused {
|
|
t.Fatal("wrong result")
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestQuirkSortIPAddrs(t *testing.T) {
|
|
addrs := []string{
|
|
"::1",
|
|
"192.168.1.2",
|
|
"2a00:1450:4002:404::2004",
|
|
"142.250.184.36",
|
|
"2604:8800:5000:82:466:38ff:fecb:d46e",
|
|
"198.145.29.83",
|
|
"95.216.163.36",
|
|
}
|
|
expected := []string{
|
|
"192.168.1.2",
|
|
"142.250.184.36",
|
|
"198.145.29.83",
|
|
"95.216.163.36",
|
|
"::1",
|
|
"2a00:1450:4002:404::2004",
|
|
"2604:8800:5000:82:466:38ff:fecb:d46e",
|
|
}
|
|
out := quirkSortIPAddrs(addrs)
|
|
if diff := cmp.Diff(expected, out); diff != "" {
|
|
t.Fatal(diff)
|
|
}
|
|
}
|