8a0beee808
What do I mean by pivoting? Netx is currently organized by row:
```
| dialer | quicdialer | resolver | ...
saving | | | | ...
errorwrapping | | | | ...
logging | | | | ...
mocking/sys | | | | ...
```
Every row needs to implement saving, errorwrapping, logging, mocking (or
adapting to the system or to some underlying library).
This causes cross package dependencies and, in turn, complexity. For
example, we need the `trace` package for supporting saving.
And `dialer`, `quickdialer`, et al. need to depend on such a package.
The same goes for errorwrapping.
This arrangement further complicates testing. For example, I am
currently working on https://github.com/ooni/probe/issues/1505 and
I realize it need to repeat integration tests in multiple places.
Let's say instead we pivot the above matrix as follows:
```
| saving | errorwrapping | logging | ...
dialer | | | | ...
quicdialer | | | | ...
logging | | | | ...
mocking/sys | | | | ...
...
```
In this way, now every row contains everything related to a specific
action to perform. We can now share code without relying on extra
support packages. What's more, we can write tests and, judding from
the way in which things are made, it seems we only need integration
testing in `errorwrapping` because it's where data quality matters
whereas, in all other cases, unit testing is fine.
I am going, therefore, to proceed with these changes and "pivot"
`netx`. Hopefully, it won't be too painful.
113 lines
3.0 KiB
Go
113 lines
3.0 KiB
Go
package resolver_test
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
"net/http"
|
|
"testing"
|
|
|
|
"github.com/apex/log"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/netx/resolver"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite"
|
|
)
|
|
|
|
func init() {
|
|
log.SetLevel(log.DebugLevel)
|
|
}
|
|
|
|
func testresolverquick(t *testing.T, reso resolver.Resolver) {
|
|
if testing.Short() {
|
|
t.Skip("skip test in short mode")
|
|
}
|
|
reso = netxlite.ResolverLogger{Logger: log.Log, Resolver: reso}
|
|
addrs, err := reso.LookupHost(context.Background(), "dns.google.com")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if addrs == nil {
|
|
t.Fatal("expected non-nil addrs here")
|
|
}
|
|
var foundquad8 bool
|
|
for _, addr := range addrs {
|
|
// See https://github.com/ooni/probe-cli/v3/internal/engine/pull/954/checks?check_run_id=1182269025
|
|
if addr == "8.8.8.8" || addr == "2001:4860:4860::8888" {
|
|
foundquad8 = true
|
|
}
|
|
}
|
|
if !foundquad8 {
|
|
t.Fatalf("did not find 8.8.8.8 in output; output=%+v", addrs)
|
|
}
|
|
}
|
|
|
|
// Ensuring we can handle Internationalized Domain Names (IDNs) without issues
|
|
func testresolverquickidna(t *testing.T, reso resolver.Resolver) {
|
|
if testing.Short() {
|
|
t.Skip("skip test in short mode")
|
|
}
|
|
reso = resolver.IDNAResolver{
|
|
netxlite.ResolverLogger{Logger: log.Log, Resolver: reso},
|
|
}
|
|
addrs, err := reso.LookupHost(context.Background(), "яндекс.рф")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if addrs == nil {
|
|
t.Fatal("expected non-nil addrs here")
|
|
}
|
|
}
|
|
|
|
func TestNewResolverSystem(t *testing.T) {
|
|
reso := netxlite.ResolverSystem{}
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverUDPAddress(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverUDP(new(net.Dialer), "8.8.8.8:53"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverUDPDomain(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverUDP(new(net.Dialer), "dns.google.com:53"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverTCPAddress(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverTCP(new(net.Dialer).DialContext, "8.8.8.8:53"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverTCPDomain(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverTCP(new(net.Dialer).DialContext, "dns.google.com:53"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverDoTAddress(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverTLS(resolver.DialTLSContext, "8.8.8.8:853"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverDoTDomain(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverTLS(resolver.DialTLSContext, "dns.google.com:853"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|
|
|
|
func TestNewResolverDoH(t *testing.T) {
|
|
reso := resolver.NewSerialResolver(
|
|
resolver.NewDNSOverHTTPS(http.DefaultClient, "https://cloudflare-dns.com/dns-query"))
|
|
testresolverquick(t, reso)
|
|
testresolverquickidna(t, reso)
|
|
}
|