83440cf110
The legacy part for now is internal/errorsx. It will stay there until I figure out whether it also needs some extra bug fixing. The good part is now in internal/netxlite/errorsx and contains all the logic for mapping errors. We need to further improve upon this logic by writing more thorough integration tests for QUIC. We also need to copy the various dialer, conn, etc adapters that set errors. We will put them inside netxlite and we will generate errors in a way that is less crazy with respect to the major operation. (The idea is to always wrap, given that now we measure in an incremental way and we don't measure every operation together.) Part of https://github.com/ooni/probe/issues/1591
157 lines
3.7 KiB
Go
157 lines
3.7 KiB
Go
package errorsx
|
|
|
|
import (
|
|
"context"
|
|
"crypto/tls"
|
|
"errors"
|
|
"io"
|
|
"net"
|
|
"testing"
|
|
|
|
"github.com/lucas-clemente/quic-go"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite/errorsx"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite/mocks"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite/quicx"
|
|
)
|
|
|
|
func TestErrorWrapperQUICListenerSuccess(t *testing.T) {
|
|
ql := &ErrorWrapperQUICListener{
|
|
QUICListener: &mocks.QUICListener{
|
|
MockListen: func(addr *net.UDPAddr) (quicx.UDPLikeConn, error) {
|
|
return &net.UDPConn{}, nil
|
|
},
|
|
},
|
|
}
|
|
pconn, err := ql.Listen(&net.UDPAddr{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
pconn.Close()
|
|
}
|
|
|
|
func TestErrorWrapperQUICListenerFailure(t *testing.T) {
|
|
ql := &ErrorWrapperQUICListener{
|
|
QUICListener: &mocks.QUICListener{
|
|
MockListen: func(addr *net.UDPAddr) (quicx.UDPLikeConn, error) {
|
|
return nil, io.EOF
|
|
},
|
|
},
|
|
}
|
|
pconn, err := ql.Listen(&net.UDPAddr{})
|
|
if err.Error() != "eof_error" {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if pconn != nil {
|
|
t.Fatal("expected nil pconn here")
|
|
}
|
|
}
|
|
|
|
func TestErrorWrapperUDPConnWriteToSuccess(t *testing.T) {
|
|
quc := &errorWrapperUDPConn{
|
|
UDPLikeConn: &mocks.QUICUDPConn{
|
|
MockWriteTo: func(p []byte, addr net.Addr) (int, error) {
|
|
return 10, nil
|
|
},
|
|
},
|
|
}
|
|
pkt := make([]byte, 128)
|
|
addr := &net.UDPAddr{}
|
|
cnt, err := quc.WriteTo(pkt, addr)
|
|
if err != nil {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if cnt != 10 {
|
|
t.Fatal("expected 10 here")
|
|
}
|
|
}
|
|
|
|
func TestErrorWrapperUDPConnWriteToFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
quc := &errorWrapperUDPConn{
|
|
UDPLikeConn: &mocks.QUICUDPConn{
|
|
MockWriteTo: func(p []byte, addr net.Addr) (int, error) {
|
|
return 0, expected
|
|
},
|
|
},
|
|
}
|
|
pkt := make([]byte, 128)
|
|
addr := &net.UDPAddr{}
|
|
cnt, err := quc.WriteTo(pkt, addr)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if cnt != 0 {
|
|
t.Fatal("expected 0 here")
|
|
}
|
|
}
|
|
|
|
func TestErrorWrapperUDPConnReadFromSuccess(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
quc := &errorWrapperUDPConn{
|
|
UDPLikeConn: &mocks.QUICUDPConn{
|
|
MockReadFrom: func(b []byte) (int, net.Addr, error) {
|
|
return 0, nil, expected
|
|
},
|
|
},
|
|
}
|
|
b := make([]byte, 128)
|
|
n, addr, err := quc.ReadFrom(b)
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if n != 0 {
|
|
t.Fatal("expected 0 here")
|
|
}
|
|
if addr != nil {
|
|
t.Fatal("expected nil here")
|
|
}
|
|
}
|
|
|
|
func TestErrorWrapperUDPConnReadFromFailure(t *testing.T) {
|
|
quc := &errorWrapperUDPConn{
|
|
UDPLikeConn: &mocks.QUICUDPConn{
|
|
MockReadFrom: func(b []byte) (int, net.Addr, error) {
|
|
return 10, nil, nil
|
|
},
|
|
},
|
|
}
|
|
b := make([]byte, 128)
|
|
n, addr, err := quc.ReadFrom(b)
|
|
if err != nil {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if n != 10 {
|
|
t.Fatal("expected 10 here")
|
|
}
|
|
if addr != nil {
|
|
t.Fatal("expected nil here")
|
|
}
|
|
}
|
|
|
|
func TestErrorWrapperQUICDialerFailure(t *testing.T) {
|
|
ctx := context.Background()
|
|
d := &ErrorWrapperQUICDialer{Dialer: &mocks.QUICContextDialer{
|
|
MockDialContext: func(ctx context.Context, network, address string, tlsConfig *tls.Config, quicConfig *quic.Config) (quic.EarlySession, error) {
|
|
return nil, io.EOF
|
|
},
|
|
}}
|
|
sess, err := d.DialContext(
|
|
ctx, "udp", "www.google.com:443", &tls.Config{}, &quic.Config{})
|
|
if sess != nil {
|
|
t.Fatal("expected a nil sess here")
|
|
}
|
|
if !errors.Is(err, io.EOF) {
|
|
t.Fatal("expected another error here")
|
|
}
|
|
var errWrapper *errorsx.ErrWrapper
|
|
if !errors.As(err, &errWrapper) {
|
|
t.Fatal("cannot cast to ErrWrapper")
|
|
}
|
|
if errWrapper.Operation != errorsx.QUICHandshakeOperation {
|
|
t.Fatal("unexpected Operation")
|
|
}
|
|
if errWrapper.Failure != errorsx.FailureEOFError {
|
|
t.Fatal("unexpected failure")
|
|
}
|
|
}
|