ooni-probe-cli/internal/cli
Simone Basso 7cde93fca4
Make sure ooniprobe show <id> is WAI (#61)
1. the description of the command and the helper function are
clear hints that the command is intended to show a single JSON
measurement at a time (also the use case seems clear) [*]

2. the function used to read lines was failing for all my
measurements that take input. Since that was not the optimal
pattern anyway, use a better pattern to fix it.

3. some changes are automatically applied by my editor (VSCode
with the Go plugin) and I am fine with them.

4. while reading code, I also applied my preferred pattern
wrt whitespaces, i.e.: no whitespace inside functions, if a
function feels too long in this way, just break it.

Closes #57

[*] Even if we want to show many measurements at a time, which
does not seem needed, given the UI patterns, this functionality
won't be P0. What is P0 is to bless a new beta and give to
@sarathms binaries for all archs that support a basic `show`.
2019-10-03 11:18:07 +02:00
..
app Use ooni/probe-engine: episode 1 (#42) 2019-05-23 16:38:46 +02:00
geoip Use ooni/probe-engine: episode 1 (#42) 2019-05-23 16:38:46 +02:00
info Add info and reset commands 2018-09-10 15:15:29 +02:00
list Make sure ooniprobe show <id> is WAI (#61) 2019-10-03 11:18:07 +02:00
onboard Exit with non-zero code when trying to do interactive onboarding and --batch is set 2018-09-17 16:16:56 +02:00
reset Close the DB before deleting ooni_home 2018-09-26 15:09:59 +02:00
rm Add rm command to delete results 2018-09-18 09:54:27 +02:00
root Upgrade to ooni/probe-engine@v0.1.1 (#60) 2019-10-03 09:43:25 +02:00
run Upgrade to ooni/probe-engine@v0.1.1 (#60) 2019-10-03 09:43:25 +02:00
show Make sure ooniprobe show <id> is WAI (#61) 2019-10-03 11:18:07 +02:00
upload Write to output when a function is not implemented 2018-06-25 13:19:54 +02:00
version Use ooni/probe-engine: episode 1 (#42) 2019-05-23 16:38:46 +02:00