ooni-probe-cli/internal/engine/geolocate
Simone Basso fbee736e90
fix(geolocate): no proxy when discovering our IP address (#251)
* fix(geolocate): no proxy when discovering our IP address

The use case of --proxy is that you cannot contact the OONI
backend otherwise. It is wrong, though, using the proxy when
discovering our IP address. The measurement won't use the
proxy anyway. Therefore, we need to use the IP address that
is performing the measurement. Not the one of the proxy.

What's more, stun is not using a proxy. Therefore, it does
not make much sense that http IP resolvers use a proxy. This
leads to inconsistencies. So, here's anothe reason why this
patch is a good thing (TM).

Finally, because knowing the IP address enables us to sanitize
the data, it's important we discover the correct IP.

Now, up until this point, the `--proxy` option has mostly
been a developers toy. But, users have asked us to have the
possibility of configuring a proxy.

This explains why I have been looking into making `--proxy`
right for a couple of hours now.

See https://github.com/ooni/probe/issues/1382

* fix(session): properly configure the IP lookupper
2021-03-10 12:01:08 +01:00
..
avast_test.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
avast.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
fake_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
geolocate_test.go fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
geolocate.go fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
invalid_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
ipconfig_test.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
ipconfig.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
ipinfo_test.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
ipinfo.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
iplookup_test.go fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
iplookup.go fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
mmdblookup_test.go feat: use go1.16 and resources embedding (#235) 2021-03-02 12:08:24 +01:00
mmdblookup.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
README.md chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
resolverlookup_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
resolverlookup.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
stun_test.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
stun.go fix(geolocate): no proxy when discovering our IP address (#251) 2021-03-10 12:01:08 +01:00
ubuntu_test.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00
ubuntu.go refactor: move more commands to internal/cmd (#207) 2021-02-03 12:23:15 +01:00

Package github.com/ooni/probe-engine/geolocate

Package geolocate implements IP lookup, resolver lookup, and geolocation.