730373cc75
We recently started moving core data structures inside of the internal/model package as detailed in https://github.com/ooni/probe/issues/1885. The chief reason to do that is to have a set of fundamental shared data types to help us rationalize the codebase. This specific diff moves internal/netx/archival's core data types inside the internal/model package. While there, it also refactors the existing tests to improve their quality. Additionally, we also added an extra test to ensure `ArchivalHTTPBody` is an alias for `ArchivalMaybeBinaryData`, which is required to ensure the custom JSON serialization process works for it. We're doing that because both internal/netx/archival and internal/measurex define their own archival data structures. We developed measurex using its own structures because it allowed to iterate more quickly. Now that we have sketched out measurex, the time has come to consolidate. My overall aim is to spend a few more hours this week on engineering measurex. This work is preliminary work before we finish up both measurex and websteps. We described this cleanup in https://github.com/ooni/probe/issues/1957. |
||
|---|---|---|
| .. | ||
| mocks | ||
| archival_test.go | ||
| archival.go | ||
| doc.go | ||
| experiment_test.go | ||
| experiment.go | ||
| keyvaluestore.go | ||
| logger_test.go | ||
| logger.go | ||
| measurement_test.go | ||
| measurement.go | ||
| netx.go | ||
| ooapi.go | ||
| README.md | ||
Package github.com/ooni/probe-engine/model
Shared data structures and interfaces. We include in this
package the most fundamental types. Use go doc to get
more thorough documentation about what is inside this package
and when to put a type inside this package.