ooni-probe-cli/internal/engine/netx/tracex
Simone Basso 66fd1569b8
tracex: prepare HTTP code for future refactoring (#778)
The main issue I see inside tracex at the moment is that we
construct the HTTP measurement from separate events.

This is fragile because we cannot be sure that these events
belong to the same round trip. (Currently, they _are_ part
of the same round trip, but this is a fragile assumption and
it would be much more robust to dispose of it.)

To prepare for emitting a single event, it's imperative to
have two distinct fields for HTTP request and response headers,
which is the main contribution in this commit.

Then, we have a bunch of smaller changes including:

1. correctly naming 'response' the DNS response (instead of 'reply')

2. ensure we always use pointer receivers

Reference issue: https://github.com/ooni/probe/issues/2121
2022-06-01 15:20:28 +02:00
..
archival_test.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
archival.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
dialer_test.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00
dialer.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00
doc.go refactor(tracex): start applying recent code conventions (#773) 2022-06-01 07:44:54 +02:00
event.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
http_test.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
http.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
quic_test.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00
quic.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00
resolver_test.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
resolver.go tracex: prepare HTTP code for future refactoring (#778) 2022-06-01 15:20:28 +02:00
saver_test.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00
saver.go refactor(netxlite): better integration with tracex (#774) 2022-06-01 08:31:20 +02:00
tls_test.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00
tls.go refactor(tracex): do not depend on strings for event names (#777) 2022-06-01 14:32:16 +02:00