d922bd9afc
The objective is to make PR checks run much faster. See https://github.com/ooni/probe/issues/2113 for context. Regarding netxlite's tests: Checking for every commit on master or on a release branch is good enough and makes pull requests faster than one minute since netxlite for windows is now 1m slower than coverage. We're losing some coverage but coverage from integration tests is not so good anyway, so I'm not super sad about this loss.
166 lines
3.7 KiB
Go
166 lines
3.7 KiB
Go
package ndt7
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/gorilla/websocket"
|
|
)
|
|
|
|
func TestDownloadSetReadDeadlineFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
mgr := newDownloadManager(
|
|
&mockableConnMock{
|
|
ReadDeadlineErr: expected,
|
|
},
|
|
defaultCallbackPerformance,
|
|
defaultCallbackJSON,
|
|
)
|
|
err := mgr.run(context.Background())
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestDownloadNextReaderFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
mgr := newDownloadManager(
|
|
&mockableConnMock{
|
|
NextReaderErr: expected,
|
|
},
|
|
defaultCallbackPerformance,
|
|
defaultCallbackJSON,
|
|
)
|
|
err := mgr.run(context.Background())
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestDownloadTextMessageReadAllFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
mgr := newDownloadManager(
|
|
&mockableConnMock{
|
|
NextReaderMsgType: websocket.TextMessage,
|
|
NextReaderReader: func() io.Reader {
|
|
return &alwaysFailingReader{
|
|
Err: expected,
|
|
}
|
|
},
|
|
},
|
|
defaultCallbackPerformance,
|
|
defaultCallbackJSON,
|
|
)
|
|
err := mgr.run(context.Background())
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
type alwaysFailingReader struct {
|
|
Err error
|
|
}
|
|
|
|
func (r *alwaysFailingReader) Read(p []byte) (int, error) {
|
|
return 0, r.Err
|
|
}
|
|
|
|
func TestDownloadBinaryMessageReadAllFailure(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
mgr := newDownloadManager(
|
|
&mockableConnMock{
|
|
NextReaderMsgType: websocket.BinaryMessage,
|
|
NextReaderReader: func() io.Reader {
|
|
return &alwaysFailingReader{
|
|
Err: expected,
|
|
}
|
|
},
|
|
},
|
|
defaultCallbackPerformance,
|
|
defaultCallbackJSON,
|
|
)
|
|
err := mgr.run(context.Background())
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
func TestDownloadOnJSONCallbackError(t *testing.T) {
|
|
mgr := newDownloadManager(
|
|
&mockableConnMock{
|
|
NextReaderMsgType: websocket.TextMessage,
|
|
NextReaderReader: func() io.Reader {
|
|
return &invalidJSONReader{}
|
|
},
|
|
},
|
|
defaultCallbackPerformance,
|
|
func(data []byte) error {
|
|
var v interface{}
|
|
return json.Unmarshal(data, &v)
|
|
},
|
|
)
|
|
err := mgr.run(context.Background())
|
|
if err == nil || !strings.HasSuffix(err.Error(), "unexpected end of JSON input") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
}
|
|
|
|
type invalidJSONReader struct{}
|
|
|
|
func (r *invalidJSONReader) Read(p []byte) (int, error) {
|
|
return copy(p, []byte(`{`)), io.EOF
|
|
}
|
|
|
|
func TestDownloadOnJSONLoop(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skip test in short mode")
|
|
}
|
|
mgr := newDownloadManager(
|
|
&mockableConnMock{
|
|
NextReaderMsgType: websocket.TextMessage,
|
|
NextReaderReader: func() io.Reader {
|
|
return &goodJSONReader{}
|
|
},
|
|
},
|
|
defaultCallbackPerformance,
|
|
func(data []byte) error {
|
|
var v interface{}
|
|
return json.Unmarshal(data, &v)
|
|
},
|
|
)
|
|
ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
|
|
defer cancel()
|
|
err := mgr.run(ctx)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
type goodJSONReader struct{}
|
|
|
|
func (r *goodJSONReader) Read(p []byte) (int, error) {
|
|
return copy(p, []byte(`{}`)), io.EOF
|
|
}
|
|
|
|
func TestDownloadReduceErr(t *testing.T) {
|
|
mgr := downloadManager{}
|
|
if mgr.reduceErr(context.Canceled) != nil {
|
|
t.Fatal("reduceErr not working as intended for context.Canceled")
|
|
}
|
|
if mgr.reduceErr(context.DeadlineExceeded) != nil {
|
|
t.Fatal("reduceErr not working as intended for context.DeadlineExceeded")
|
|
}
|
|
if mgr.reduceErr(nil) != nil {
|
|
t.Fatal("reduceErr not working as intended for nil")
|
|
}
|
|
expected := errors.New("mocked error")
|
|
if mgr.reduceErr(expected) != expected {
|
|
t.Fatal("reduceErr not working as intended for other errors")
|
|
}
|
|
}
|