ooni-probe-cli/internal/engine/netx/tlsdialer
Simone Basso 60a3c372f5
cleanup: remove the original netx implementation (#653)
This commit completely removes the original netx implementation,
which was only used by `tor`, since this has changed in
https://github.com/ooni/probe-cli/pull/652.

The original netx implementation was my first attempt at performing
network measurements using Go. It started its life inside of the
https://github.com/ooni/netx repository. It was later merged into
the https://github.com/ooni/probe-engine repository. It finally
ended up into this repository when we merged probe-engine with it.

The main issue with the original implementation is that it was
a bit too complex and used channels where they were probably not
necessary. Because of that, later I introduced a second netx
implementation, which currently lives in ./internal/engine/netx.

The current netx implementation, the third one, lives in the
./internal/netxlite package. We are currently working to replace
the second implementation with the third one, but this is happening
at a slow pace. Also, the second implementation does not have big
maintenance concerns but it's just a bit too bureaucratic to use
since it involves creating lots of `Config` structures.

The reference issue is probably https://github.com/ooni/probe/issues/1688,
since this diff has been enabled by rewriting Tor to use `measurex`
(a library living on top of `netxlite`).
2022-01-05 19:00:50 +01:00
..
eof_test.go refactor(netx): extract tlsdialer from dialer 2021-06-08 12:52:15 +02:00
fake_test.go refactor(netx): extract tlsdialer from dialer 2021-06-08 12:52:15 +02:00
integration_test.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
saver_test.go refactor: merge dnsx and errorsx into netxlite (#517) 2021-09-28 12:42:01 +02:00
saver.go refactor: merge tlsx into netxlite (#403) 2021-06-25 12:39:45 +02:00
tls_test.go cleanup: remove the original netx implementation (#653) 2022-01-05 19:00:50 +01:00
tls.go cleanup: remove the original netx implementation (#653) 2022-01-05 19:00:50 +01:00