2e0118d1a6
## Description This PR continues the refactoring of `netx` under the following principles: 1. do not break the rest of the tree and do not engage in extensive tree-wide refactoring yet 2. move under `netxlite` clearly related subpackages (e.g., `iox`, `netxmocks`) 3. move into `internal/netxlite/internal` stuff that is clearly private of `netxlite` 4. hide implementation details in `netxlite` pending new factories 5. refactor `tls` code in `netxlite` to clearly separate `crypto/tls` code from `utls` code After each commit, I run `go test -short -race ./...` locally. Each individual commit explains what it does. I will squash, but this operation will preserve the original commit titles, so this will give further insight on each step. ## Commits * refactor: rename netxmocks -> netxlite/mocks Part of https://github.com/ooni/probe/issues/1591 * refactor: rename quicx -> netxlite/quicx See https://github.com/ooni/probe/issues/1591 * refactor: rename iox -> netxlite/iox Regenerate sources and make sure the tests pass. See https://github.com/ooni/probe/issues/1591. * refactor(iox): move MockableReader to netxlite/mocks See https://github.com/ooni/probe/issues/1591 * refactor(netxlite): generator is an implementation detail See https://github.com/ooni/probe/issues/1591 * refactor(netxlite): separate tls and utls code See https://github.com/ooni/probe/issues/1591 * refactor(netxlite): hide most types but keep old names as legacy With this change we avoid breaking the rest of the tree, but we start hiding some implementation details a bit. Factories will follow. See https://github.com/ooni/probe/issues/1591
78 lines
2.3 KiB
Go
78 lines
2.3 KiB
Go
package resolver
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
"errors"
|
|
"net/http"
|
|
"time"
|
|
|
|
"github.com/ooni/probe-cli/v3/internal/engine/httpheader"
|
|
"github.com/ooni/probe-cli/v3/internal/netxlite/iox"
|
|
)
|
|
|
|
// DNSOverHTTPS is a DNS over HTTPS RoundTripper. Requests are submitted over
|
|
// an HTTP/HTTPS channel provided by URL using the Do function.
|
|
type DNSOverHTTPS struct {
|
|
Do func(req *http.Request) (*http.Response, error)
|
|
URL string
|
|
HostOverride string
|
|
}
|
|
|
|
// NewDNSOverHTTPS creates a new DNSOverHTTP instance from the
|
|
// specified http.Client and URL, as a convenience.
|
|
func NewDNSOverHTTPS(client *http.Client, URL string) DNSOverHTTPS {
|
|
return NewDNSOverHTTPSWithHostOverride(client, URL, "")
|
|
}
|
|
|
|
// NewDNSOverHTTPSWithHostOverride is like NewDNSOverHTTPS except that
|
|
// it's creating a resolver where we use the specified host.
|
|
func NewDNSOverHTTPSWithHostOverride(client *http.Client, URL, hostOverride string) DNSOverHTTPS {
|
|
return DNSOverHTTPS{Do: client.Do, URL: URL, HostOverride: hostOverride}
|
|
}
|
|
|
|
// RoundTrip implements RoundTripper.RoundTrip.
|
|
func (t DNSOverHTTPS) RoundTrip(ctx context.Context, query []byte) ([]byte, error) {
|
|
ctx, cancel := context.WithTimeout(ctx, 45*time.Second)
|
|
defer cancel()
|
|
req, err := http.NewRequest("POST", t.URL, bytes.NewReader(query))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
req.Host = t.HostOverride
|
|
req.Header.Set("user-agent", httpheader.UserAgent())
|
|
req.Header.Set("content-type", "application/dns-message")
|
|
var resp *http.Response
|
|
resp, err = t.Do(req.WithContext(ctx))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
defer resp.Body.Close()
|
|
if resp.StatusCode != 200 {
|
|
// TODO(bassosimone): we should map the status code to a
|
|
// proper Error in the DNS context.
|
|
return nil, errors.New("doh: server returned error")
|
|
}
|
|
if resp.Header.Get("content-type") != "application/dns-message" {
|
|
return nil, errors.New("doh: invalid content-type")
|
|
}
|
|
return iox.ReadAllContext(ctx, resp.Body)
|
|
}
|
|
|
|
// RequiresPadding returns true for DoH according to RFC8467
|
|
func (t DNSOverHTTPS) RequiresPadding() bool {
|
|
return true
|
|
}
|
|
|
|
// Network returns the transport network (e.g., doh, dot)
|
|
func (t DNSOverHTTPS) Network() string {
|
|
return "doh"
|
|
}
|
|
|
|
// Address returns the upstream server address.
|
|
func (t DNSOverHTTPS) Address() string {
|
|
return t.URL
|
|
}
|
|
|
|
var _ RoundTripper = DNSOverHTTPS{}
|