9b08dcac3f
This bug is one of these bugs that definitely help one to stay humble and focused on improving the codebase. Of course I `<facepalmed>` when I understood the root cause. We did not move the annotations below the `if` which is checking whether the measurement was successful when we refactored the codebase to support returning multiple measurements per run, which happened in https://github.com/ooni/probe-cli/pull/527. While I am not going to whip myself too much because of this, it's clearly a bummer that we didn't notice this bug back then. On top of this, it's also quite sad it took us so much time to notice that there was this bug inside the tree. The lesson (hopefully) learned is probably that we need to be more careful when we refactor and we should always ask the question of whether, not only we have tests, but whether these tests could maybe be improved to give us even more confidence about correctness. The reference issue is https://github.com/ooni/probe/issues/2173. |
||
|---|---|---|
| .. | ||
| oonimkall | ||
| .gitignore | ||
| README.md | ||
Directory github.com/ooni/probe-cli/pkg
This directory contains public Go packages.