6895946a34
With this factory, we want to construct ourselves the TLS dialer so that we can use a dialer wrapper that always sets timeouts when reading, addressing https://github.com/ooni/probe/issues/1609. As a result, we cannot immediately replace the i/e/netx factory for creating a new HTTP transport, since the functions signatures are not directly compatible. Refactoring is part of https://github.com/ooni/probe/issues/1505.
151 lines
3.5 KiB
Go
151 lines
3.5 KiB
Go
package netxlite
|
|
|
|
import (
|
|
"context"
|
|
"crypto/tls"
|
|
"errors"
|
|
"io"
|
|
"net"
|
|
"net/http"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/apex/log"
|
|
"github.com/ooni/probe-cli/v3/internal/atomicx"
|
|
"github.com/ooni/probe-cli/v3/internal/iox"
|
|
"github.com/ooni/probe-cli/v3/internal/netxmocks"
|
|
)
|
|
|
|
func TestHTTPTransportLoggerFailure(t *testing.T) {
|
|
txp := &HTTPTransportLogger{
|
|
Logger: log.Log,
|
|
HTTPTransport: &netxmocks.HTTPTransport{
|
|
MockRoundTrip: func(req *http.Request) (*http.Response, error) {
|
|
return nil, io.EOF
|
|
},
|
|
},
|
|
}
|
|
client := &http.Client{Transport: txp}
|
|
resp, err := client.Get("https://www.google.com")
|
|
if !errors.Is(err, io.EOF) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if resp != nil {
|
|
t.Fatal("expected nil response here")
|
|
}
|
|
}
|
|
|
|
func TestHTTPTransportLoggerFailureWithNoHostHeader(t *testing.T) {
|
|
foundHost := &atomicx.Int64{}
|
|
txp := &HTTPTransportLogger{
|
|
Logger: log.Log,
|
|
HTTPTransport: &netxmocks.HTTPTransport{
|
|
MockRoundTrip: func(req *http.Request) (*http.Response, error) {
|
|
if req.Header.Get("Host") == "www.google.com" {
|
|
foundHost.Add(1)
|
|
}
|
|
return nil, io.EOF
|
|
},
|
|
},
|
|
}
|
|
req := &http.Request{
|
|
Header: http.Header{},
|
|
URL: &url.URL{
|
|
Scheme: "https",
|
|
Host: "www.google.com",
|
|
Path: "/",
|
|
},
|
|
}
|
|
resp, err := txp.RoundTrip(req)
|
|
if !errors.Is(err, io.EOF) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if resp != nil {
|
|
t.Fatal("expected nil response here")
|
|
}
|
|
if foundHost.Load() != 1 {
|
|
t.Fatal("host header was not added")
|
|
}
|
|
}
|
|
|
|
func TestHTTPTransportLoggerSuccess(t *testing.T) {
|
|
txp := &HTTPTransportLogger{
|
|
Logger: log.Log,
|
|
HTTPTransport: &netxmocks.HTTPTransport{
|
|
MockRoundTrip: func(req *http.Request) (*http.Response, error) {
|
|
return &http.Response{
|
|
Body: io.NopCloser(strings.NewReader("")),
|
|
Header: http.Header{
|
|
"Server": []string{"antani/0.1.0"},
|
|
},
|
|
StatusCode: 200,
|
|
}, nil
|
|
},
|
|
},
|
|
}
|
|
client := &http.Client{Transport: txp}
|
|
resp, err := client.Get("https://www.google.com")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
iox.ReadAllContext(context.Background(), resp.Body)
|
|
resp.Body.Close()
|
|
}
|
|
|
|
func TestHTTPTransportLoggerCloseIdleConnections(t *testing.T) {
|
|
calls := &atomicx.Int64{}
|
|
txp := &HTTPTransportLogger{
|
|
HTTPTransport: &netxmocks.HTTPTransport{
|
|
MockCloseIdleConnections: func() {
|
|
calls.Add(1)
|
|
},
|
|
},
|
|
Logger: log.Log,
|
|
}
|
|
txp.CloseIdleConnections()
|
|
if calls.Load() != 1 {
|
|
t.Fatal("not called")
|
|
}
|
|
}
|
|
|
|
func TestHTTPTransportWorks(t *testing.T) {
|
|
d := &DialerResolver{
|
|
Dialer: DefaultDialer,
|
|
Resolver: &net.Resolver{},
|
|
}
|
|
th := &TLSHandshakerConfigurable{}
|
|
txp := NewHTTPTransport(d, &tls.Config{}, th)
|
|
client := &http.Client{Transport: txp}
|
|
resp, err := client.Get("https://www.google.com/robots.txt")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
resp.Body.Close()
|
|
txp.CloseIdleConnections()
|
|
}
|
|
|
|
func TestHTTPTransportWithFailingDialer(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
d := &DialerResolver{
|
|
Dialer: &netxmocks.Dialer{
|
|
MockDialContext: func(ctx context.Context,
|
|
network, address string) (net.Conn, error) {
|
|
return nil, expected
|
|
},
|
|
},
|
|
Resolver: &net.Resolver{},
|
|
}
|
|
th := &TLSHandshakerConfigurable{}
|
|
txp := NewHTTPTransport(d, &tls.Config{}, th)
|
|
client := &http.Client{Transport: txp}
|
|
resp, err := client.Get("https://www.google.com/robots.txt")
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if resp != nil {
|
|
t.Fatal("expected non-nil response here")
|
|
}
|
|
txp.CloseIdleConnections()
|
|
}
|