ooni-probe-cli/internal/engine/netx/dialer
Simone Basso 314c3c934d
refactor(session.go): replace engine/netx with netxlite (#767)
This diff replaces engine/netx code with netxlite code in
the engine/session.go file. To this end, we needed to move
some code from engine/netx to netxlite. While there, we
did review and improve the unit tests.

A notable change in this diff is (or seems to be) that in
engine/session.go we're not filtering for bogons anymore so
that, in principle, we could believe a resolver returning
to us bogon IP addresses for OONI services. However, I did
not bother with changing bogons filtering because the
sessionresolver package is already filtering for bogons,
so it is actually okay to avoid doing that again the
session.go code. See:

https://github.com/ooni/probe-cli/blob/v3.15.0-alpha.1/internal/engine/internal/sessionresolver/resolvermaker.go#L88

There are two reference issues for this cleanup:

1. https://github.com/ooni/probe/issues/2115

2. https://github.com/ooni/probe/issues/2121
2022-05-30 22:00:45 +02:00
..
bytecounter_test.go feat(torsf): collect tor logs, select rendezvous method, count bytes (#683) 2022-02-07 17:05:36 +01:00
bytecounter.go feat(torsf): collect tor logs, select rendezvous method, count bytes (#683) 2022-02-07 17:05:36 +01:00
dialer_test.go refactor: only use shaping dialer for ndt7 and dash (#754) 2022-05-24 18:23:42 +02:00
dialer.go refactor: only use shaping dialer for ndt7 and dash (#754) 2022-05-24 18:23:42 +02:00
doc.go refactor(netx/dialer): hide implementation complexity (#372) 2021-06-09 09:42:31 +02:00
example_test.go cleanup: remove unnecessary legacy interfaces (#656) 2022-01-07 18:33:37 +01:00
integration_test.go cleanup: remove unnecessary legacy interfaces (#656) 2022-01-07 18:33:37 +01:00
proxy.go refactor(session.go): replace engine/netx with netxlite (#767) 2022-05-30 22:00:45 +02:00
saver_test.go refactor: move httpx into the internal package (#646) 2022-01-05 17:17:20 +01:00
saver.go cleanup: remove unnecessary legacy interfaces (#656) 2022-01-07 18:33:37 +01:00