2bafb179c3
* refactor(tunnel): remove nil tunnels hack This code was originally introduced because a tunnel could be nil in session.go. I have verified that every invocation of tunnel.Start is careful to ensure that we have a tunnel name and that we don't manipulate a nil tunnel. For this reason, I'd rather remove this tricky bit of code and further simplify the tunnel code. Part of https://github.com/ooni/probe/issues/985 * even better docs
80 lines
1.7 KiB
Go
80 lines
1.7 KiB
Go
package tunnel
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/apex/log"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/internal/mockable"
|
|
)
|
|
|
|
func TestStartNoTunnel(t *testing.T) {
|
|
ctx := context.Background()
|
|
tunnel, err := Start(ctx, &Config{
|
|
Name: "",
|
|
Session: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
})
|
|
if !errors.Is(err, ErrUnsupportedTunnelName) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if tunnel != nil {
|
|
t.Fatal("expected nil tunnel here")
|
|
}
|
|
}
|
|
|
|
func TestStartPsiphonWithCancelledContext(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel() // fail immediately
|
|
tunnel, err := Start(ctx, &Config{
|
|
Name: "psiphon",
|
|
Session: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
TunnelDir: "testdata",
|
|
})
|
|
if !errors.Is(err, context.Canceled) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if tunnel != nil {
|
|
t.Fatal("expected nil tunnel here")
|
|
}
|
|
}
|
|
|
|
func TestStartTorWithCancelledContext(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel() // fail immediately
|
|
tunnel, err := Start(ctx, &Config{
|
|
Name: "tor",
|
|
Session: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
TunnelDir: "testdata",
|
|
})
|
|
if !errors.Is(err, context.Canceled) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if tunnel != nil {
|
|
t.Fatal("expected nil tunnel here")
|
|
}
|
|
}
|
|
|
|
func TestStartInvalidTunnel(t *testing.T) {
|
|
ctx := context.Background()
|
|
tunnel, err := Start(ctx, &Config{
|
|
Name: "antani",
|
|
Session: &mockable.Session{
|
|
MockableLogger: log.Log,
|
|
},
|
|
TunnelDir: "testdata",
|
|
})
|
|
if !errors.Is(err, ErrUnsupportedTunnelName) {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if tunnel != nil {
|
|
t.Fatal("expected nil tunnel here")
|
|
}
|
|
}
|