1fd2b1fd53
* feat(oonimkall): instrument code to understand CI issue It seems ~difficult to reproduce the problem locally and I could not see it after five runs of ``` go test -race -count 1 ./pkg/oonimkall/... ``` So, here's some diagnostic code that could help understanding the reference issue https://github.com/ooni/probe/issues/1785. Also, it seems the issue pops up much more frequently when running CI anyway. So, I am going to leave this diff around and when it appears again I have more context to fix the issue. * fix(oonimkall): skip flaky test in short mode See https://github.com/ooni/probe/issues/1785
77 lines
1.9 KiB
Go
77 lines
1.9 KiB
Go
package tasks
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
|
|
engine "github.com/ooni/probe-cli/v3/internal/engine"
|
|
)
|
|
|
|
func TestMeasurementSubmissionEventName(t *testing.T) {
|
|
if measurementSubmissionEventName(nil) != statusMeasurementSubmission {
|
|
t.Fatal("unexpected submission event name")
|
|
}
|
|
if measurementSubmissionEventName(errors.New("mocked error")) != failureMeasurementSubmission {
|
|
t.Fatal("unexpected submission event name")
|
|
}
|
|
}
|
|
|
|
func TestMeasurementSubmissionFailure(t *testing.T) {
|
|
if measurementSubmissionFailure(nil) != "" {
|
|
t.Fatal("unexpected submission failure")
|
|
}
|
|
if measurementSubmissionFailure(errors.New("mocked error")) != "mocked error" {
|
|
t.Fatal("unexpected submission failure")
|
|
}
|
|
}
|
|
|
|
func TestRunnerMaybeLookupLocationFailure(t *testing.T) {
|
|
if testing.Short() {
|
|
// TODO(https://github.com/ooni/probe-cli/pull/518)
|
|
t.Skip("skip test in short mode")
|
|
}
|
|
out := make(chan *Event)
|
|
settings := &Settings{
|
|
AssetsDir: "../../testdata/oonimkall/assets",
|
|
Name: "Example",
|
|
Options: SettingsOptions{
|
|
SoftwareName: "oonimkall-test",
|
|
SoftwareVersion: "0.1.0",
|
|
},
|
|
StateDir: "../../testdata/oonimkall/state",
|
|
Version: 1,
|
|
}
|
|
seench := make(chan int64)
|
|
go func() {
|
|
var seen int64
|
|
for ev := range out {
|
|
switch ev.Key {
|
|
case "failure.ip_lookup", "failure.asn_lookup",
|
|
"failure.cc_lookup", "failure.resolver_lookup":
|
|
seen++
|
|
case "status.progress":
|
|
evv := ev.Value.(EventStatusProgress)
|
|
if evv.Percentage >= 0.2 {
|
|
panic(fmt.Sprintf("too much progress: %+v", ev))
|
|
}
|
|
case "status.queued", "status.started", "status.end":
|
|
default:
|
|
panic(fmt.Sprintf("unexpected key: %s - %+v", ev.Key, ev.Value))
|
|
}
|
|
}
|
|
seench <- seen
|
|
}()
|
|
expected := errors.New("mocked error")
|
|
r := NewRunner(settings, out)
|
|
r.maybeLookupLocation = func(*engine.Session) error {
|
|
return expected
|
|
}
|
|
r.Run(context.Background())
|
|
close(out)
|
|
if n := <-seench; n != 4 {
|
|
t.Fatal("unexpected number of events")
|
|
}
|
|
}
|