d57c78bc71
This is how I did it: 1. `git clone https://github.com/ooni/probe-engine internal/engine` 2. ``` (cd internal/engine && git describe --tags) v0.23.0 ``` 3. `nvim go.mod` (merging `go.mod` with `internal/engine/go.mod` 4. `rm -rf internal/.git internal/engine/go.{mod,sum}` 5. `git add internal/engine` 6. `find . -type f -name \*.go -exec sed -i 's@/ooni/probe-engine@/ooni/probe-cli/v3/internal/engine@g' {} \;` 7. `go build ./...` (passes) 8. `go test -race ./...` (temporary failure on RiseupVPN) 9. `go mod tidy` 10. this commit message Once this piece of work is done, we can build a new version of `ooniprobe` that is using `internal/engine` directly. We need to do more work to ensure all the other functionality in `probe-engine` (e.g. making mobile packages) are still WAI. Part of https://github.com/ooni/probe/issues/1335
114 lines
2.8 KiB
Go
114 lines
2.8 KiB
Go
package resolver_test
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/miekg/dns"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/netx/resolver"
|
|
)
|
|
|
|
func TestDecoderUnpackError(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(dns.TypeA, nil)
|
|
if err == nil {
|
|
t.Fatal("expected an error here")
|
|
}
|
|
if data != nil {
|
|
t.Fatal("expected nil data here")
|
|
}
|
|
}
|
|
|
|
func TestDecoderNXDOMAIN(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(dns.TypeA, resolver.GenReplyError(t, dns.RcodeNameError))
|
|
if err == nil || !strings.HasSuffix(err.Error(), "no such host") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if data != nil {
|
|
t.Fatal("expected nil data here")
|
|
}
|
|
}
|
|
|
|
func TestDecoderOtherError(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(dns.TypeA, resolver.GenReplyError(t, dns.RcodeRefused))
|
|
if err == nil || !strings.HasSuffix(err.Error(), "query failed") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if data != nil {
|
|
t.Fatal("expected nil data here")
|
|
}
|
|
}
|
|
|
|
func TestDecoderNoAddress(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(dns.TypeA, resolver.GenReplySuccess(t, dns.TypeA))
|
|
if err == nil || !strings.HasSuffix(err.Error(), "no response returned") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if data != nil {
|
|
t.Fatal("expected nil data here")
|
|
}
|
|
}
|
|
|
|
func TestDecoderDecodeA(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(
|
|
dns.TypeA, resolver.GenReplySuccess(t, dns.TypeA, "1.1.1.1", "8.8.8.8"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(data) != 2 {
|
|
t.Fatal("expected two entries here")
|
|
}
|
|
if data[0] != "1.1.1.1" {
|
|
t.Fatal("invalid first IPv4 entry")
|
|
}
|
|
if data[1] != "8.8.8.8" {
|
|
t.Fatal("invalid second IPv4 entry")
|
|
}
|
|
}
|
|
|
|
func TestDecoderDecodeAAAA(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(
|
|
dns.TypeAAAA, resolver.GenReplySuccess(t, dns.TypeAAAA, "::1", "fe80::1"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(data) != 2 {
|
|
t.Fatal("expected two entries here")
|
|
}
|
|
if data[0] != "::1" {
|
|
t.Fatal("invalid first IPv6 entry")
|
|
}
|
|
if data[1] != "fe80::1" {
|
|
t.Fatal("invalid second IPv6 entry")
|
|
}
|
|
}
|
|
|
|
func TestDecoderUnexpectedAReply(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(
|
|
dns.TypeA, resolver.GenReplySuccess(t, dns.TypeAAAA, "::1", "fe80::1"))
|
|
if err == nil || !strings.HasSuffix(err.Error(), "no response returned") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if data != nil {
|
|
t.Fatal("expected nil data here")
|
|
}
|
|
}
|
|
|
|
func TestDecoderUnexpectedAAAAReply(t *testing.T) {
|
|
d := resolver.MiekgDecoder{}
|
|
data, err := d.Decode(
|
|
dns.TypeAAAA, resolver.GenReplySuccess(t, dns.TypeA, "1.1.1.1", "8.8.4.4."))
|
|
if err == nil || !strings.HasSuffix(err.Error(), "no response returned") {
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if data != nil {
|
|
t.Fatal("expected nil data here")
|
|
}
|
|
}
|