ooni-probe-cli/internal/engine/netx
Simone Basso 0fdc9cafb5
fix(all): introduce and use iox.ReadAllContext (#379)
* fix(all): introduce and use iox.ReadAllContext

This improvement over the ioutil.ReadAll utility returns early
if the context expires. This enables us to unblock stuck code in
case there's censorship confounding the TCP stack.

See https://github.com/ooni/probe/issues/1417.

Compared to the functionality postulated in the above mentioned
issue, I choose to be more generic and separate limiting the
maximum body size (not implemented here) from using the context
to return early when reading a body (or any other reader).

After implementing iox.ReadAllContext, I made sure we always
use it everywhere in the tree instead of ioutil.ReadAll.

This includes many parts of the codebase where in theory we don't
need iox.ReadAllContext. Though, changing all the places makes
checking whether we're not using ioutil.ReadAll where we should
not be using it easy: `git grep` should return no lines.

* Update internal/iox/iox_test.go

* fix(ndt7): treat context errors as non-errors

The rationale is explained by the comment documenting reduceErr.

* Update internal/engine/experiment/ndt7/download.go
2021-06-15 11:57:40 +02:00
..
archival refactor: remove model.ExperimentOrchestraClient (#284) 2021-04-02 12:03:18 +02:00
bytecounter refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
dialer refactor(netx/dialer): hide implementation complexity (#372) 2021-06-09 09:42:31 +02:00
errorx release 3.9.0 process: reduce warnings (#279) 2021-03-31 15:59:19 +02:00
httptransport fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
mockablex refactor(netx): move dialer's mockable types in mockablex (#368) 2021-06-08 23:59:30 +02:00
quicdialer quic: use RFC9000 version (#376) 2021-06-14 16:59:24 +02:00
resolver fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
tlsdialer refactor(netx/dialer): hide implementation complexity (#372) 2021-06-09 09:42:31 +02:00
tlsx fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
trace chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
fake_test.go fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
integration_test.go fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
netx_internal_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
netx_test.go refactor(netx/dialer): hide implementation complexity (#372) 2021-06-09 09:42:31 +02:00
netx.go refactor(netx/dialer): hide implementation complexity (#372) 2021-06-09 09:42:31 +02:00
README.md chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00

Package github.com/ooni/probe-engine/netx

OONI extensions to the net and net/http packages. This code is used by ooni/probe-engine as a low level library to collect network, DNS, and HTTP events occurring during OONI measurements.

This library contains replacements for commonly used standard library interfaces that facilitate seamless network measurements. By using such replacements, as opposed to standard library interfaces, we can:

  • save the timing of HTTP events (e.g. received response headers)
  • save the timing and result of every Connect, Read, Write, Close operation
  • save the timing and result of the TLS handshake (including certificates)

By default, this library uses the system resolver. In addition, it is possible to configure alternative DNS transports and remote servers. We support DNS over UDP, DNS over TCP, DNS over TLS (DoT), and DNS over HTTPS (DoH). When using an alternative transport, we are also able to intercept and save DNS messages, as well as any other interaction with the remote server (e.g., the result of the TLS handshake for DoT and DoH).

This package is a fork of github.com/ooni/netx.