ooni-probe-cli/internal/engine/legacy/netx
Simone Basso 0fdc9cafb5
fix(all): introduce and use iox.ReadAllContext (#379)
* fix(all): introduce and use iox.ReadAllContext

This improvement over the ioutil.ReadAll utility returns early
if the context expires. This enables us to unblock stuck code in
case there's censorship confounding the TCP stack.

See https://github.com/ooni/probe/issues/1417.

Compared to the functionality postulated in the above mentioned
issue, I choose to be more generic and separate limiting the
maximum body size (not implemented here) from using the context
to return early when reading a body (or any other reader).

After implementing iox.ReadAllContext, I made sure we always
use it everywhere in the tree instead of ioutil.ReadAll.

This includes many parts of the codebase where in theory we don't
need iox.ReadAllContext. Though, changing all the places makes
checking whether we're not using ioutil.ReadAll where we should
not be using it easy: `git grep` should return no lines.

* Update internal/iox/iox_test.go

* fix(ndt7): treat context errors as non-errors

The rationale is explained by the comment documenting reduceErr.

* Update internal/engine/experiment/ndt7/download.go
2021-06-15 11:57:40 +02:00
..
connid chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
dialid refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
handlers refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
modelx release 3.9.0 process: reduce warnings (#279) 2021-03-31 15:59:19 +02:00
oldhttptransport fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
testdata chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
transactionid refactor: flatten and separate (#353) 2021-06-04 10:34:18 +02:00
DESIGN.md chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
dialer_test.go release 3.9.0 process: reduce warnings (#279) 2021-03-31 15:59:19 +02:00
dialer.go fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
emitterdialer_test.go refactor(netx): towards removing connid, dialid, etc (#369) 2021-06-09 00:15:33 +02:00
emitterdialer.go refactor(netx): towards removing connid, dialid, etc (#369) 2021-06-09 00:15:33 +02:00
http_test.go fix(all): introduce and use iox.ReadAllContext (#379) 2021-06-15 11:57:40 +02:00
http.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
resolver_internal_test.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00
resolver_test.go Release 3.6.0 (#239) 2021-03-03 14:42:17 +01:00
resolver.go chore: merge probe-engine into probe-cli (#201) 2021-02-02 12:05:47 +01:00