Go to file
Simone Basso 0a630c1716
refactor(measurex): allow to configure timeouts and max-snapshot-size (#645)
This diff lightly refactors the code in measurex to allow a user
to configure all possible timeouts and the max-snapshot-size.

There is currently a little bit of tension between setting timeouts
inside of measurex and the watchdog timeouts inside of netxlite.

This tension has been documented.

Let us repeat the issue also in this commit message. If you are
using a masurex.Measurer configured with very large timeouts and
the underlying netxlite implementation uses shorter whatchdog
timeouts, then you are going to see shorter than expected timeouts.

Ideally, we would like to have just a single timeout but there is
no way to ask the context "hey, can you tell me if you already have
a configured timeout?".

It may be that the right solution is to modify netxlite to have
some sort of root/library object with this configuration.

If that's the case, then a Measurer could be refactored as follows:

- create the underlying netxlite "library"

- initialize the timeouts desired by the Measurer

- create a Dialer, of whatever is needed

- use it

Now this is not possible because netxlite timeouts are internal
static settings rather than attributes of a structure.

Anyway, for now I'm happy with this just being documented.

(I suspect this issue will need to be addresses when we'll write
unit tests for measurex; at that time a proper solution should
come out naturally due to the unit tests constraints.)

I'm working on this refactoring, BTW, to facilitate rewriting `tor`
using measurex (see https://github.com/ooni/probe/issues/1688).
2022-01-04 13:20:48 +01:00
.github/workflows [forwardport] release 3.11: update all the dependencies (#636) (#637) 2021-12-06 17:46:13 +01:00
.vscode feat(make): sign more generated binaries (#330) 2021-05-05 14:26:19 +02:00
CLI [forwardport] ci/cd: publish binaries onto a release when we create a tag (#609) (#611) 2021-11-23 15:56:25 +01:00
cmd refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
docs [forwardport] ci/cd: publish binaries onto a release when we create a tag (#609) (#611) 2021-11-23 15:56:25 +01:00
E2E fix(ci/debianrepo): avoid running docker arm64 (#551) 2021-10-21 16:55:00 +02:00
internal refactor(measurex): allow to configure timeouts and max-snapshot-size (#645) 2022-01-04 13:20:48 +01:00
MOBILE fix(template.podspec): refer to the .xcframework 2021-12-07 14:42:19 +01:00
pkg refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
QA feat(QA): add test cases for websteps vs webconnectivity (#583) 2021-11-05 15:56:04 +01:00
testdata feat: introduce ptx package for pluggable transports dialers (#373) 2021-06-14 10:20:54 +02:00
.eslintrc.json feat(QA): add test cases for websteps vs webconnectivity (#583) 2021-11-05 15:56:04 +01:00
.gitignore feat(QA): add test cases for websteps vs webconnectivity (#583) 2021-11-05 15:56:04 +01:00
CODE_OF_CONDUCT.md doc: add code of conduct (#157) 2020-11-03 21:16:04 +01:00
CODEOWNERS chore: continue merging probe-engine into probe-cli (#211) 2021-02-03 14:42:51 +01:00
CONTRIBUTING.md [forwardport] ci/cd: publish binaries onto a release when we create a tag (#609) (#611) 2021-11-23 15:56:25 +01:00
go.mod feature: use go-libtor on mobile, OONI_TOR_BINARY env on desktop (#614) 2021-12-15 14:16:22 +01:00
go.sum feature: use go-libtor on mobile, OONI_TOR_BINARY env on desktop (#614) 2021-12-15 14:16:22 +01:00
LICENSE feat: relicense the repository under GNU GPLv3 (#446) 2021-08-20 14:50:46 +02:00
mk [forwardport] release 3.11: update all the dependencies (#636) (#637) 2021-12-06 17:46:13 +01:00
PULL_REQUEST_TEMPLATE.md fix: improve the pull request template (#439) 2021-08-18 11:46:37 +02:00
Readme.md fix(Readme.md): add explicit SPDX identifier (#641) 2021-12-16 09:56:15 +01:00
testjafar.bash refactor: enable QA tests and jafar self test (#208) 2021-02-03 13:20:37 +01:00

OONI Probe Client Library and CLI

GoDoc Short Tests Status Coverage Status Go Report Card linux-debian-packages

The Open Observatory of Network Interference (OONI) is a non-profit free software project that aims to empower decentralized efforts in documenting Internet censorship around the world.

This repository contains core OONI tools written in Go:

Every top-level directory in this repository contains an explanatory README file.

License

SPDX-License-Identifier: GPL-3.0-or-later

User setup

Please, follow the instructions at ooni.org/install/cli to install ooniprobe. If we do not support your use case, please let us know. Once ooniprobe is installed, try ooniprobe help to get interactive help.

Reporting issues

Report issues at github.com/ooni/probe. Please, make sure you add the ooni/probe-cli label.

Build instructions

ooniprobe

Be sure you have golang >= 1.17 and a C compiler (Mingw-w64 for Windows). You can build using:

go build -v ./cmd/ooniprobe

This will generate a binary called ooniprobe in the current directory.

Android bindings

Make sure you have GNU make installed, then run:

./mk android

to build bindings for Android. (Add OONI_PSIPHON_TAGS="" if you cannot clone private repositories in the https://github.com/ooni namespace.)

The generated bindings are (manually) pushed to the Maven Central package repository. The instructions explaining how to integrate these bindings are published along with the release notes.

iOS bindings

Make sure you have GNU make installed, then run:

./mk ios

to build bindings for iOS. (Add OONI_PSIPHON_TAGS="" if you cannot clone private repositories in the https://github.com/ooni namespace.)

The generated bindings are (manually) added to GitHub releases. The instructions explaining how to integrate these bindings are published along with the release notes.

miniooni

Miniooni is the experimental OONI client used for research. Compile using:

go build -v ./internal/cmd/miniooni

This will generate a binary called miniooni in the current directory.

oohelperd

Oohelperd is the test helper server. Compile using:

go build -v ./internal/cmd/oohelperd

This will generate a binary called oohelperd in the current directory.

Specifications

Every nettest (aka experiment) implemented in this repository has a companion spec in the ooni/spec repository.

Contributing

Please, see CONTRIBUTING.md.

Updating dependencies

go get -u -v ./... && go mod tidy

Releasing

Create an issue according to the routine release template and perform any item inside the check-list.

We build releases using ./mk, which requires GNU make. Try the ./mk help|less command for detailed usage.