ooni-probe-cli/internal/tracex
Simone Basso b78b9aca51
refactor(datafmt): use "udp" instead of "quic" (#946)
This diff changes the data format to prefer "udp" to "quic" everywhere we were previously using "quic".

Previously, the code inconsistently used "quic" for operations where we knew we were using "quic" and "udp" otherwise (e.g., for generic operations like ReadFrom).

While it would be more correct to say that a specific HTTP request used "quic" rather than "udp", using "udp" consistently allows one to see how distinct events such as ReadFrom and an handshake all refer to the same address, port, and protocol triple. Therefore, this change makes it easier to programmatically unpack a single measurement and create endpoint stats.

Before implementing this change, I discussed the problem with @hellais who mentioned that ooni/data is not currently using the "quic" string anywhere. I know that ooni/pipeline also doesn't rely on this string. The only users of this feature have been research-oriented experiments such as urlgetter, for which such a change would actually be acceptable.

See https://github.com/ooni/probe/issues/2238 and https://github.com/ooni/spec/pull/262.
2022-09-08 17:19:59 +02:00
..
archival_test.go refactor(datafmt): use "udp" instead of "quic" (#946) 2022-09-08 17:19:59 +02:00
archival.go refactor: make measurex depend on measurexlite (#892) 2022-08-28 21:41:58 +02:00
dialer_test.go refactor(tracex): internally represent errors as strings (#786) 2022-06-02 10:37:07 +02:00
dialer.go refactor(tracex): internally represent errors as strings (#786) 2022-06-02 10:37:07 +02:00
doc.go feat: tlsping and tcpping using step-by-step (#815) 2022-07-01 12:22:22 +02:00
event_test.go chore: improve testing and increase coverage (#794) 2022-06-04 14:58:48 +02:00
event.go feat(oonirun): improve tests (#915) 2022-08-31 18:40:27 +02:00
http_test.go refactor(netx): move construction logic outside package (#798) 2022-06-05 21:22:27 +02:00
http.go fix(tracex): use HTTP transaction end time for t (#925) 2022-09-02 15:10:57 +02:00
quic_test.go chore: upgrade deps and attempt to enable using go1.19 (#869) 2022-08-19 11:26:50 +02:00
quic.go chore: upgrade deps and attempt to enable using go1.19 (#869) 2022-08-19 11:26:50 +02:00
resolver_test.go feat: clearly indicate which resolver we're using (#885) 2022-08-27 15:47:48 +02:00
resolver.go feat: clearly indicate which resolver we're using (#885) 2022-08-27 15:47:48 +02:00
saver_test.go refactor: move tracex outside of engine/netx (#782) 2022-06-02 00:50:55 +02:00
saver.go refactor: move tracex outside of engine/netx (#782) 2022-06-02 00:50:55 +02:00
tls_test.go chore: improve testing and increase coverage (#794) 2022-06-04 14:58:48 +02:00
tls.go refactor(tracex): internally store just the raw certificate (#787) 2022-06-02 11:07:02 +02:00