01a513a496
This diff refactors the DNSTransport model to receive in input a DNSQuery and return in output a DNSResponse. The design of DNSQuery and DNSResponse takes into account the use case of a transport using getaddrinfo, meaning that we don't need to serialize and deserialize messages when using getaddrinfo. The current codebase does not use a getaddrinfo transport, but I wrote one such a transport in the Websteps Winter 2021 prototype (https://github.com/bassosimone/websteps-illustrated/). The design conversation that lead to producing this diff is https://github.com/ooni/probe/issues/2099
75 lines
1.5 KiB
Go
75 lines
1.5 KiB
Go
package mocks
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/ooni/probe-cli/v3/internal/atomicx"
|
|
"github.com/ooni/probe-cli/v3/internal/model"
|
|
)
|
|
|
|
func TestDNSTransport(t *testing.T) {
|
|
t.Run("RoundTrip", func(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
txp := &DNSTransport{
|
|
MockRoundTrip: func(ctx context.Context, query model.DNSQuery) (model.DNSResponse, error) {
|
|
return nil, expected
|
|
},
|
|
}
|
|
resp, err := txp.RoundTrip(context.Background(), &DNSQuery{})
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("not the error we expected", err)
|
|
}
|
|
if resp != nil {
|
|
t.Fatal("expected nil response here")
|
|
}
|
|
})
|
|
|
|
t.Run("RequiresPadding", func(t *testing.T) {
|
|
txp := &DNSTransport{
|
|
MockRequiresPadding: func() bool {
|
|
return true
|
|
},
|
|
}
|
|
if txp.RequiresPadding() != true {
|
|
t.Fatal("unexpected result")
|
|
}
|
|
})
|
|
|
|
t.Run("Network", func(t *testing.T) {
|
|
txp := &DNSTransport{
|
|
MockNetwork: func() string {
|
|
return "antani"
|
|
},
|
|
}
|
|
if txp.Network() != "antani" {
|
|
t.Fatal("unexpected result")
|
|
}
|
|
})
|
|
|
|
t.Run("Address", func(t *testing.T) {
|
|
txp := &DNSTransport{
|
|
MockAddress: func() string {
|
|
return "mascetti"
|
|
},
|
|
}
|
|
if txp.Address() != "mascetti" {
|
|
t.Fatal("unexpected result")
|
|
}
|
|
})
|
|
|
|
t.Run("CloseIdleConnections", func(t *testing.T) {
|
|
called := &atomicx.Int64{}
|
|
txp := &DNSTransport{
|
|
MockCloseIdleConnections: func() {
|
|
called.Add(1)
|
|
},
|
|
}
|
|
txp.CloseIdleConnections()
|
|
if called.Load() != 1 {
|
|
t.Fatal("not called")
|
|
}
|
|
})
|
|
}
|