01a513a496
This diff refactors the DNSTransport model to receive in input a DNSQuery and return in output a DNSResponse. The design of DNSQuery and DNSResponse takes into account the use case of a transport using getaddrinfo, meaning that we don't need to serialize and deserialize messages when using getaddrinfo. The current codebase does not use a getaddrinfo transport, but I wrote one such a transport in the Websteps Winter 2021 prototype (https://github.com/bassosimone/websteps-illustrated/). The design conversation that lead to producing this diff is https://github.com/ooni/probe/issues/2099
27 lines
557 B
Go
27 lines
557 B
Go
package mocks
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/ooni/probe-cli/v3/internal/model"
|
|
)
|
|
|
|
func TestDNSDecoder(t *testing.T) {
|
|
t.Run("DecodeResponse", func(t *testing.T) {
|
|
expected := errors.New("mocked error")
|
|
e := &DNSDecoder{
|
|
MockDecodeResponse: func(reply []byte, query model.DNSQuery) (model.DNSResponse, error) {
|
|
return nil, expected
|
|
},
|
|
}
|
|
out, err := e.DecodeResponse(make([]byte, 17), &DNSQuery{})
|
|
if !errors.Is(err, expected) {
|
|
t.Fatal("unexpected err", err)
|
|
}
|
|
if out != nil {
|
|
t.Fatal("unexpected out")
|
|
}
|
|
})
|
|
}
|