ooni-probe-cli/internal/measurex
Simone Basso b78b9aca51
refactor(datafmt): use "udp" instead of "quic" (#946)
This diff changes the data format to prefer "udp" to "quic" everywhere we were previously using "quic".

Previously, the code inconsistently used "quic" for operations where we knew we were using "quic" and "udp" otherwise (e.g., for generic operations like ReadFrom).

While it would be more correct to say that a specific HTTP request used "quic" rather than "udp", using "udp" consistently allows one to see how distinct events such as ReadFrom and an handshake all refer to the same address, port, and protocol triple. Therefore, this change makes it easier to programmatically unpack a single measurement and create endpoint stats.

Before implementing this change, I discussed the problem with @hellais who mentioned that ooni/data is not currently using the "quic" string anywhere. I know that ooni/pipeline also doesn't rely on this string. The only users of this feature have been research-oriented experiments such as urlgetter, for which such a change would actually be acceptable.

See https://github.com/ooni/probe/issues/2238 and https://github.com/ooni/spec/pull/262.
2022-09-08 17:19:59 +02:00
..
archival.go fix(measurex): handle case where TH is nil (#610) 2021-11-22 20:16:38 +01:00
db.go fix(measurex): use same keys of the OONI data format (#572) 2021-11-05 10:46:45 +01:00
dialer.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
dnsx_test.go feat: clearly indicate which resolver we're using (#885) 2022-08-27 15:47:48 +02:00
dnsx.go feat: clearly indicate which resolver we're using (#885) 2022-08-27 15:47:48 +02:00
doc.go feat: tlsping and tcpping using step-by-step (#815) 2022-07-01 12:22:22 +02:00
easy.go refactor(tor): rewrite using measurex (#652) 2022-01-05 18:41:11 +01:00
endpoint.go refactor(datafmt): use "udp" instead of "quic" (#946) 2022-09-08 17:19:59 +02:00
failure.go refactor: make measurex depend on measurexlite (#892) 2022-08-28 21:41:58 +02:00
http.go cleanup: merge httpheader and httpfailure into model (#758) 2022-05-25 09:54:50 +02:00
logger.go refactor: make measurex depend on measurexlite (#892) 2022-08-28 21:41:58 +02:00
measurement.go refactor(datafmt): use "udp" instead of "quic" (#946) 2022-09-08 17:19:59 +02:00
measurer.go refactor(datafmt): use "udp" instead of "quic" (#946) 2022-09-08 17:19:59 +02:00
oddity.go feat(measurex): refactored measurement library (#528) 2021-09-30 01:24:08 +02:00
quic.go refactor(datafmt): use "udp" instead of "quic" (#946) 2022-09-08 17:19:59 +02:00
resolver_test.go feat: clearly indicate which resolver we're using (#885) 2022-08-27 15:47:48 +02:00
resolver.go feat: clearly indicate which resolver we're using (#885) 2022-08-27 15:47:48 +02:00
tls.go refactor: interfaces and data types into the model package (#642) 2022-01-03 13:53:23 +01:00
tracing.go cleanup: netx does not use netxlite legacy names (#801) 2022-06-06 14:46:44 +02:00
utils.go refactor(datafmt): use "udp" instead of "quic" (#946) 2022-09-08 17:19:59 +02:00