99ec7ffca9
Since https://github.com/ooni/probe-cli/pull/527, if an experiment returns an error, the corresponding measurement is not submitted since the semantics of returning an error is that something fundamental went wrong (e.g., we could not parse the input URL). This diff ensures that all experiments only return and error when something fundamental was wrong and return nil otherwise. Reference issue: https://github.com/ooni/probe/issues/1808.
91 lines
2.5 KiB
Go
91 lines
2.5 KiB
Go
package urlgetter_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/apex/log"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/experiment/urlgetter"
|
|
"github.com/ooni/probe-cli/v3/internal/engine/mockable"
|
|
"github.com/ooni/probe-cli/v3/internal/model"
|
|
)
|
|
|
|
func TestMeasurer(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel()
|
|
m := urlgetter.NewExperimentMeasurer(urlgetter.Config{})
|
|
if m.ExperimentName() != "urlgetter" {
|
|
t.Fatal("invalid experiment name")
|
|
}
|
|
if m.ExperimentVersion() != "0.2.0" {
|
|
t.Fatal("invalid experiment version")
|
|
}
|
|
measurement := new(model.Measurement)
|
|
measurement.Input = "https://www.google.com"
|
|
err := m.Run(
|
|
ctx, &mockable.Session{},
|
|
measurement, model.NewPrinterCallbacks(log.Log),
|
|
)
|
|
if !errors.Is(err, nil) { // nil because we want to submit the measurement
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if len(measurement.Extensions) != 6 {
|
|
t.Fatal("not the expected number of extensions")
|
|
}
|
|
tk := measurement.TestKeys.(*urlgetter.TestKeys)
|
|
if len(tk.DNSCache) != 0 {
|
|
t.Fatal("not the DNSCache value we expected")
|
|
}
|
|
sk, err := m.GetSummaryKeys(measurement)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, ok := sk.(urlgetter.SummaryKeys); !ok {
|
|
t.Fatal("invalid type for summary keys")
|
|
}
|
|
}
|
|
|
|
func TestMeasurerDNSCache(t *testing.T) {
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
cancel()
|
|
m := urlgetter.NewExperimentMeasurer(urlgetter.Config{
|
|
DNSCache: "dns.google 8.8.8.8 8.8.4.4",
|
|
})
|
|
if m.ExperimentName() != "urlgetter" {
|
|
t.Fatal("invalid experiment name")
|
|
}
|
|
if m.ExperimentVersion() != "0.2.0" {
|
|
t.Fatal("invalid experiment version")
|
|
}
|
|
measurement := new(model.Measurement)
|
|
measurement.Input = "https://www.google.com"
|
|
err := m.Run(
|
|
ctx, &mockable.Session{},
|
|
measurement, model.NewPrinterCallbacks(log.Log),
|
|
)
|
|
if !errors.Is(err, nil) { // nil because we want to submit the measurement
|
|
t.Fatal("not the error we expected")
|
|
}
|
|
if len(measurement.Extensions) != 6 {
|
|
t.Fatal("not the expected number of extensions")
|
|
}
|
|
tk := measurement.TestKeys.(*urlgetter.TestKeys)
|
|
if len(tk.DNSCache) != 1 || tk.DNSCache[0] != "dns.google 8.8.8.8 8.8.4.4" {
|
|
t.Fatal("invalid tk.DNSCache")
|
|
}
|
|
}
|
|
|
|
func TestSummaryKeysGeneric(t *testing.T) {
|
|
measurement := &model.Measurement{TestKeys: &urlgetter.TestKeys{}}
|
|
m := &urlgetter.Measurer{}
|
|
osk, err := m.GetSummaryKeys(measurement)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
sk := osk.(urlgetter.SummaryKeys)
|
|
if sk.IsAnomaly {
|
|
t.Fatal("invalid isAnomaly")
|
|
}
|
|
}
|