2389c7cab3
While working on https://github.com/ooni/probe/issues/2130, and specifically on the action item related to making sure all workflows are green, I was confronted with the complexity of the QA directory. There's plenty of cleaning up and simplifying there. The original intent was to A/B test `miniooni` and `measurement_kit` to ensure they were behaving the same. We don't have this need anymore. Rather, it seems the QA scripts have grown large and flaky, to the point that I am always tempted to ignore them. The underlying censorship engine, jafar, has also not been developed for quite some time. So, the first step towards improve the QA infrastructure seems to be humble and acknowledge that we cannot realistically maintain these checks using jafar as a backend for so many experiments. Let us focus on our most important experiment, Web Connectivity, and let us keep QA checks for it. Additionally, let us simplify and cleanup QA as much as possible, though without introducing radical changes. The end result is a QA for Web Connectivity that seems reasonable and runs in six minutes.
22 lines
622 B
Bash
Executable File
22 lines
622 B
Bash
Executable File
#!/bin/sh
|
|
set -euxo pipefail
|
|
|
|
# required because the container is running as root
|
|
git config --global --add safe.directory /jafar
|
|
|
|
# TODO(bassosimone): investigate why using CGO_ENABLED=1 is such
|
|
# that all DNS lookups return `dns_nxdomain_error`
|
|
export CGO_ENABLED=0
|
|
|
|
# TODO(bassosimone): because this script runs as root, it's not
|
|
# possible to save the caching directories in github actions but
|
|
# doing that would making re-executing these scripts faster.
|
|
export GOPATH=/jafar/QA/GOPATH
|
|
export GOCACHE=/jafar/QA/GOCACHE
|
|
|
|
go build -v ./internal/cmd/miniooni
|
|
|
|
go build -v ./internal/cmd/jafar
|
|
|
|
sudo ./QA/$1.py ./miniooni
|