ooni-probe-cli

Author SHA1 Message Date

Author	SHA1	Message	Date
Simone Basso	c1b06a2d09	fix(netxlite): prefer composition over embedding (#733 ) This diff has been extracted and adapted from `8848c8c516` The reason to prefer composition over embedding is that we want the build to break if we add new methods to interfaces we define. If the build does not break, we may forget about wrapping methods we should actually be wrapping. I noticed this issue inside netxlite when I was working on websteps-illustrated and I added support for NS and PTR queries. See https://github.com/ooni/probe/issues/2096 While there, perform comprehensive netxlite code review and apply minor changes and improve the docs.	2022-05-15 19:25:27 +02:00
Simone Basso	0efd4ff130	chore: import improved bogons handling code (#723 ) This diff imports improved bogons handling code from websteps winter 2022 edition's repository. See https://github.com/ooni/probe/issues/2095 See `a65f3e8579/internal/netxlite/bogon.go`	2022-05-13 15:32:47 +02:00
Simone Basso	f91de2ecd6	cleanup: move bogon checking code in netxlite (#562 ) I develop this diff while working on https://github.com/ooni/probe/issues/1803#issuecomment-957323297. While there, make sure we don't have duplicate bogon code and always use the code inside netxlite.	2021-11-02 12:20:04 +01:00

Simone Basso

c1b06a2d09

fix(netxlite): prefer composition over embedding (#733 )

This diff has been extracted and adapted from 8848c8c516

The reason to prefer composition over embedding is that we want the
build to break if we add new methods to interfaces we define. If the build
does not break, we may forget about wrapping methods we should
actually be wrapping. I noticed this issue inside netxlite when I was working
on websteps-illustrated and I added support for NS and PTR queries.

See https://github.com/ooni/probe/issues/2096

While there, perform comprehensive netxlite code review
and apply minor changes and improve the docs.

2022-05-15 19:25:27 +02:00

Simone Basso

0efd4ff130

chore: import improved bogons handling code (#723 )

This diff imports improved bogons handling code from websteps
winter 2022 edition's repository.

See https://github.com/ooni/probe/issues/2095

See a65f3e8579/internal/netxlite/bogon.go

2022-05-13 15:32:47 +02:00

Simone Basso

f91de2ecd6

cleanup: move bogon checking code in netxlite (#562 )

I develop this diff while working on https://github.com/ooni/probe/issues/1803#issuecomment-957323297.

While there, make sure we don't have duplicate bogon code
and always use the code inside netxlite.

2021-11-02 12:20:04 +01:00

3 Commits