Commit Graph

21 Commits

Author SHA1 Message Date
Simone Basso
fa803300bb refactor(ooni): introduce interfaces for testability 2020-11-20 12:19:51 +01:00
Simone Basso
7cde93fca4
Make sure ooniprobe show <id> is WAI (#61)
1. the description of the command and the helper function are
clear hints that the command is intended to show a single JSON
measurement at a time (also the use case seems clear) [*]

2. the function used to read lines was failing for all my
measurements that take input. Since that was not the optimal
pattern anyway, use a better pattern to fix it.

3. some changes are automatically applied by my editor (VSCode
with the Go plugin) and I am fine with them.

4. while reading code, I also applied my preferred pattern
wrt whitespaces, i.e.: no whitespace inside functions, if a
function feels too long in this way, just break it.

Closes #57

[*] Even if we want to show many measurements at a time, which
does not seem needed, given the UI patterns, this functionality
won't be P0. What is P0 is to bless a new beta and give to
@sarathms binaries for all archs that support a basic `show`.
2019-10-03 11:18:07 +02:00
Arturo Filastò
18a89f4cbd [schema-change] Prefix all columns that could cause conflicts 2018-09-17 17:30:38 +02:00
Arturo Filastò
4ed94dfc53 Improve the presentation of the measurement listing from the CLI 2018-09-13 14:54:56 +02:00
Arturo Filastò
b1ae8bc13e Show data usage in summary of measurements 2018-09-12 15:41:54 +02:00
Arturo Filastò
54af7170d4 Add support for data_usage event 2018-09-12 13:42:16 +02:00
Arturo Filastò
0ee0c28129 Resolve country code ambigious selection 2018-09-11 18:06:15 +02:00
Arturo Filastò
d02ed117f9 Include total_runtime in the summary of measurements 2018-09-11 16:36:09 +02:00
Arturo Filastò
8da12a9c07 Add measurement summary to list command 2018-09-11 15:40:42 +02:00
Arturo Filastò
1637fdbf93 Structured output of measurements 2018-09-10 18:03:32 +02:00
Arturo Filastò
e5c508a94c Fix bug in result listing 2018-09-10 16:56:32 +02:00
Arturo Filastò
898332064b Add result testkeys projection 2018-09-10 15:03:52 +02:00
Arturo Filastò
b29071f37b Replace summary with test_keys 2018-09-10 12:41:28 +02:00
Arturo Filastò
b727aba854 Update result listing 2018-09-07 15:39:22 +02:00
Arturo Filastò
ff2f973523 Start integrating upper/db as a new ORM 2018-09-05 18:40:37 +02:00
Arturo Filastò
eb4e6988b3 Implement quick and dirty measurement listing 2018-06-22 12:12:35 +02:00
Arturo Filastò
703b260903 Implement missing bits in result listing 2018-06-22 11:53:10 +02:00
Arturo Filastò
ecf3370f53 Implement result listing from CLI
Change the schema to include ASN and Network Name in the results table
2018-05-03 18:40:52 +02:00
Arturo Filastò
0c5b6aa37c Rename gooni to probe-cli
This is the command I used:
```
rg 'github.com/openobservatory/gooni' --files-with-matches \
    | xargs sed -i '' 's/github.com\/openobservatory\/gooni/github.com\/ooni\/probe-cli/g'
```
2018-05-03 14:59:55 +02:00
Arturo Filastò
3cdb927eb0 Implement handlers to normalise how logging is handled 2018-02-21 17:06:30 +02:00
Arturo Filastò
7327e1ff7f Start laying out the structure of gooni 2018-02-07 20:02:18 +02:00